-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/asset types #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/asset types #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6aaf990 to
14162c5
Compare
c19f100 to
bcc0758
Compare
93e8a2c to
168ba4d
Compare
thenav56
previously approved these changes
Aug 19, 2025
3a401c6 to
c8ddb5b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #108 +/- ##
===========================================
- Coverage 79.97% 79.13% -0.85%
===========================================
Files 164 168 +4
Lines 7917 8243 +326
Branches 708 758 +50
===========================================
+ Hits 6332 6523 +191
- Misses 1343 1455 +112
- Partials 242 265 +23 ☔ View full report in Codecov by Sentry. |
c8ddb5b to
4572971
Compare
- add external_url on CommonAsset
- add file and external_url to CommonAsset model
- make file non-mandatory
- add oneOf validation for file and external_url
- add input_type on ProjetAsset: AOI_GEOMETRY, OBJECT_IMAGE, COVER_IMAGE
- add input_type on ProjectAsset filter
- add export_type on ProjectAsset filter
- add asset_type_specifics on ProjectAsset
- define ObjectImage and AoiGeometry pydantic models
- add validation for AOI_GEOMETRY on serializer
- calculate bbox, center and area for AOI_GEOMETRY on serializer
4572971 to
f637528
Compare
thenav56
previously approved these changes
Aug 21, 2025
- add validation for all input types for project asset creation - add input type and validation in tutorial asset creation - remove mimetype based filtering for project asset retrieval
- change id in validate image to numeric string
- add typing for file content on asset serializers - update firebase submodule to develop
d52afce to
aa0a3c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
Changes
This PR doesn't introduce any:
printThis PR contains valid: