Skip to content

Conversation

@tnagorra
Copy link
Collaborator

@tnagorra tnagorra commented Aug 11, 2025

Depends on

Changes

  • add external_url on CommonAsset
    • add file and external_url to CommonAsset model
    • make file non-mandatory
    • add oneOf validation for file and external_url
  • add input_type on ProjetAsset: AOI_GEOMETRY, OBJECT_IMAGE, COVER_IMAGE
    • add input_type on ProjectAsset filter
    • add export_type on ProjectAsset filter
  • add asset_type_specifics on ProjectAsset
    • define ObjectImage and AoiGeometry pydantic models
    • add validation for AOI_GEOMETRY on serializer
    • calculate bbox, center and area for AOI_GEOMETRY on serializer
  • clear older DEBUG related project assets
  • add min_zoom and max_zoom for raster tiles
  • add tutorial specifics for validate_image project type
  • increase max tasks for validate image task using dataset
  • convert id fields in object image asset to numeric string

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

thenav56
thenav56 previously approved these changes Aug 19, 2025
@frozenhelium frozenhelium marked this pull request as ready for review August 20, 2025 09:47
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 57.84314% with 172 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.13%. Comparing base (3a0df80) to head (aa0a3c5).
⚠️ Report is 17 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
project_types/validate_image/project.py 36.36% 55 Missing and 1 partial ⚠️
apps/project/serializers.py 56.92% 19 Missing and 9 partials ⚠️
utils/common.py 25.92% 18 Missing and 2 partials ⚠️
apps/tutorial/serializers.py 18.18% 17 Missing and 1 partial ⚠️
apps/common/serializers.py 47.05% 5 Missing and 4 partials ⚠️
apps/project/graphql/dataloaders.py 18.18% 9 Missing ⚠️
project_types/validate_image/tutorial.py 74.19% 8 Missing ⚠️
apps/common/utils.py 60.00% 2 Missing and 4 partials ⚠️
apps/project/graphql/types/types.py 64.70% 3 Missing and 3 partials ⚠️
apps/tutorial/models.py 63.63% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
- Coverage    79.97%   79.13%   -0.85%     
===========================================
  Files          164      168       +4     
  Lines         7917     8243     +326     
  Branches       708      758      +50     
===========================================
+ Hits          6332     6523     +191     
- Misses        1343     1455     +112     
- Partials       242      265      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnagorra tnagorra marked this pull request as draft August 20, 2025 11:42
@tnagorra tnagorra force-pushed the feature/asset-types branch from c8ddb5b to 4572971 Compare August 20, 2025 12:32
tnagorra and others added 10 commits August 20, 2025 18:17
- add external_url on CommonAsset
    - add file and external_url to CommonAsset model
    - make file non-mandatory
    - add oneOf validation for file and external_url
- add input_type on ProjetAsset: AOI_GEOMETRY, OBJECT_IMAGE, COVER_IMAGE
    - add input_type on ProjectAsset filter
    - add export_type on ProjectAsset filter
- add asset_type_specifics on ProjectAsset
    - define ObjectImage and AoiGeometry pydantic models
    - add validation for AOI_GEOMETRY on serializer
    - calculate bbox, center and area for AOI_GEOMETRY on serializer
@tnagorra tnagorra force-pushed the feature/asset-types branch from 4572971 to f637528 Compare August 20, 2025 12:33
@tnagorra tnagorra marked this pull request as ready for review August 20, 2025 12:33
thenav56
thenav56 previously approved these changes Aug 21, 2025
- add validation for all input types for project asset creation
- add input type and validation in tutorial asset creation
- remove mimetype based filtering for project asset retrieval
- change id in validate image to numeric string
- add typing for file content on asset serializers
- update firebase submodule to develop
@tnagorra tnagorra merged commit 4cde36a into develop Aug 21, 2025
4 of 6 checks passed
@tnagorra tnagorra deleted the feature/asset-types branch August 21, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants