Skip to content

Conversation

@thenav56
Copy link
Member

Addresses

  • global export issues

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.67%. Comparing base (f1a9c83) to head (f13cc57).
⚠️ Report is 8 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/contributor/firebase/pull.py 50.00% 1 Missing and 1 partial ⚠️
apps/mapping/firebase/utils.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #213      +/-   ##
===========================================
+ Coverage    87.66%   87.67%   +0.01%     
===========================================
  Files          205      205              
  Lines        12278    12317      +39     
  Branches      1038     1042       +4     
===========================================
+ Hits         10763    10799      +36     
- Misses        1135     1137       +2     
- Partials       380      381       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- PROJECT_STATS_BY_TYPES (project_stats_by_types.csv)
    - Fix duplicate rows
- PROJECTS_CSV (projects.csv)
    - Add firebase_id
- PROJECTS_CENTROID_GEOJSON (projects_geom.geojson)
    - Add firebase_id
    - Fix geometry null issue
    - Remove geom from property
- PROJECTS_GEOM_GEOJSON (projects_geom.geojson)
    - Add firebase_id
    - Fix geometry null issue
    - Remove geom from property
@thenav56 thenav56 force-pushed the fix/global-exports branch 2 times, most recently from e553d3c to f13cc57 Compare November 3, 2025 06:34
@thenav56 thenav56 marked this pull request as ready for review November 3, 2025 07:19
@susilnem susilnem merged commit b83cea6 into develop Nov 3, 2025
6 checks passed
@susilnem susilnem deleted the fix/global-exports branch November 3, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants