Skip to content

Conversation

@tnagorra
Copy link
Collaborator

@tnagorra tnagorra commented Aug 2, 2025

Depends on

Changes

  • firebase: send null to firebase if data is missing
  • firebase: use firebase_id instead of id or old_id where missing
  • firebase: update use of latest firebase schema (with deprecation support)
  • firebase: remove deprecated comments
  • firebase: define projectTopicKey, usernameKey nameKey
  • firebase: fix issue with required projectDetails field
  • pydantic: fix warning on usage of pydantic.input all_fieldsAddresses
  • firebase: validate data before updating the data
  • firebase: add inheritance checks to FirebasePush

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

- use firebase_id instead of id or old_id where missing
- firebase: update use of latest firebase schema (with deprecation support)
- firebase: remove deprecated comments
- firebase: define projectTopicKey, usernameKey nameKey
- firebase: fix issue with required projectDetails field
- pydantic: fix warning on usage of pydantic.input all_fields
- add inheritance checks to FirebasePush
@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

❌ Patch coverage is 65.78947% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.94%. Comparing base (c24bd9d) to head (3209921).
⚠️ Report is 7 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/common/firebase.py 45.83% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #88      +/-   ##
===========================================
- Coverage    82.05%   81.94%   -0.12%     
===========================================
  Files          145      145              
  Lines         6086     6103      +17     
  Branches       517      522       +5     
===========================================
+ Hits          4994     5001       +7     
- Misses         911      918       +7     
- Partials       181      184       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnagorra tnagorra marked this pull request as ready for review August 3, 2025 09:53
@tnagorra tnagorra force-pushed the feat/null-firebase-sync branch from a34d103 to 0420fb1 Compare August 3, 2025 09:57
- to avoid waiting for firebase simulator to start
@tnagorra tnagorra force-pushed the feat/null-firebase-sync branch from 0420fb1 to 3209921 Compare August 3, 2025 10:00
@tnagorra tnagorra merged commit 4c70e82 into develop Aug 3, 2025
4 of 6 checks passed
@tnagorra tnagorra deleted the feat/null-firebase-sync branch August 3, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants