Skip to content

feat: add archivable fields for organization. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susilnem merged 1 commit into from
Jul 25, 2025
Merged

feat: add archivable fields for organization. #10

susilnem merged 1 commit into from
Jul 25, 2025

Conversation

@Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Jul 18, 2025 •
edited
Loading

Changes

  • add archivable fields for organization.

tnagorra
tnagorra reviewed Jul 20, 2025
View reviewed changes
functions/definition/models.yaml Outdated
# NOTE: We can remove this
nameKey:
type: string
isArchived:
Copy link
Contributor

@tnagorra tnagorra Jul 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a NOTE that these were added on revamp.

Copy link
Contributor

@tnagorra tnagorra Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thenav56 Should we add all of these fields?

Copy link
Contributor

@tnagorra tnagorra Jul 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the conversation with @thenav56, let's only add isArchived.
It can be an optional field.

@tnagorra tnagorra requested a review from susilnem July 21, 2025 06:16
@tnagorra tnagorra self-assigned this Jul 21, 2025
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as draft July 21, 2025 09:50
@tnagorra tnagorra changed the title chore(organization): add archivable fields for organization. feat: add archivable fields for organization. Jul 21, 2025
@tnagorra tnagorra marked this pull request as ready for review July 21, 2025 13:26
@tnagorra tnagorra mentioned this pull request Jul 21, 2025
Merged
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/organization branch 2 times, most recently from 538a2b0 to 7d1cc7a Compare July 24, 2025 04:33
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi mentioned this pull request Jul 24, 2025
Merged
9 tasks
@susilnem susilnem force-pushed the feature/organization branch from cbb6866 to 2e43a4c Compare July 25, 2025 05:13
@susilnem susilnem merged commit f83846f into develop Jul 25, 2025
2 checks passed
@susilnem susilnem deleted the feature/organization branch July 25, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnagorra tnagorra tnagorra left review comments

@susilnem susilnem susilnem approved these changes

Assignees

@tnagorra tnagorra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rup-Narayan-Rajbanshi @tnagorra @susilnem