RD-1292 RD-1293 Add Leaflet control (v1.5 - v2-alpha) #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katemihalikova
force-pushed
the
RD-1292-RD-1293-leaflet
branch
from
a13c166 to
c6c29c6
Compare
katemihalikova
force-pushed
the
RD-1292-RD-1293-leaflet
branch
from
f1ac04d to
1f63654
Compare
lesbaa
approved these changes
Dec 8, 2025
Contributor
lesbaa
left a comment
lesbaa
left a comment
There was a problem hiding this comment.
A few minor comments but in general LGTM. well documented 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-1292 RD-1293
Objective
Add a geocoding control for Leaflet in various versions.
Description
A refactored control for Leaflet with support for both v1 (>=1.5) and v2-alpha.
Acceptance
Manual testing, automated type tests with different Leaflet versions.
This PR is opened against the refactoring branch as to not clutter the #101 pull request even more. Merge this into
nextonly after #101 is merged intonext.