MLE-24892 Cleaning up test dependencies #1854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately can't upgrade to JUnit5 in ml-development-tools, far too many breaking changes to fix for now.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up test dependencies across multiple modules, removing unused test dependencies and improving documentation. The focus is on streamlining the dependency graph while acknowledging technical debt around JUnit 4/5 migration.
Key Changes
- Updated comments in ml-development-tools to clarify the decision to remain on JUnit 4
- Removed unused test dependencies (xmlunit-legacy, okhttp, gradleTestKit) from ml-development-tools
- Removed JUnit 4 dependency from marklogic-client-api and unused imports from test file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ml-development-tools/build.gradle | Updated JUnit 4 comment and removed unused test dependencies |
| marklogic-client-api/build.gradle | Removed JUnit 4 dependency that was forcing version to avoid vulnerability |
| marklogic-client-api/src/test/java/com/marklogic/client/test/rows/TransformDocTest.java | Removed unused JUnit 4 import statements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately can't upgrade to JUnit5 in ml-development-tools, far too many breaking changes to fix for now.