Merged
Conversation
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.9 to 1.19.1. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.18.9...v1.19.1) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.19.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
Updates documentation and build/deploy metadata to reflect the move from the marklogic-community GitHub org to marklogic, while also modernizing the docs (Ruby/Jekyll) GitHub Pages workflow and refreshing Ruby gem lockfile dependencies.
Changes:
- Replace
marklogic-communityGitHub URLs withmarklogicacross Gradle publishing metadata and documentation. - Update the GitHub Pages Jekyll workflow to use
ruby/setup-ruby+bundle exec jekyll build, and bump related GitHub Actions versions. - Refresh docs Ruby dependency lockfile and update a few maintenance/config details (copyright year, contributing instructions, exclusion config).
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| marklogic-unit-test-modules/build.gradle | Update POM/SCM URLs to marklogic org. |
| marklogic-unit-test-client/build.gradle | Update POM/SCM URLs to marklogic org. |
| marklogic-junit5/build.gradle | Update POM/SCM URLs to marklogic org. |
| marklogic-junit5/src/main/java/com/marklogic/junit5/spring/MarkLogicUnitTestsTest.java | Update copyright year and GitHub link in Javadoc. |
| marklogic-junit5/src/main/java/com/marklogic/junit5/dhf/DataHubUnitTestsTest.java | Update copyright year and GitHub link in Javadoc. |
| marklogic-junit5/examples/simple-ml-gradle/README.md | Update ml-gradle and marklogic-unit-test GitHub links. |
| marklogic-junit5/README.md | Update GitHub links to marklogic org. |
| docs/writing-tests.md | Update example project GitHub link. |
| docs/running-tests.md | Update marklogic-junit5 links to marklogic org. |
| docs/index.md | Update “submit an issue” link to marklogic org. |
| docs/getting-started.md | Update GitHub links to examples/releases under marklogic. |
| docs/assertion-functions.md | Update “browse the source code” link to marklogic org. |
| docs/_config.yml | Update docs site aux link label/URL to marklogic org. |
| docs/Gemfile.lock | Update locked gem versions (notably faraday/nokogiri) and platforms. |
| README.md | Update badges and user guide URL to marklogic org pages. |
| CONTRIBUTING.md | Clarify Ruby requirement as “latest Ruby 3.x”. |
| .github/workflows/jekyll-gh-pages.yml | Modernize Pages deploy workflow (checkout@v4, configure-pages@v5, deploy-pages@v4, ruby/setup-ruby + bundle build). |
| .copyrightconfig | Adjust excluded file patterns list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Setup Ruby and install Gemfile bundles | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.3.4' # Matches GH Pages; keep explicit to match .ruby-version and make CI intent clear |
There was a problem hiding this comment.
The workflow comment says the Ruby version is kept explicit to match a .ruby-version file, but there is no .ruby-version (neither repo root nor docs/). Either add the file (so local/dev + CI stay aligned) or update the comment to avoid implying a source of truth that doesn't exist.
Suggested change
| ruby-version: '3.3.4' # Matches GH Pages; keep explicit to match .ruby-version and make CI intent clear | |
| ruby-version: '3.3.4' # Matches GH Pages; keep explicit to make CI intent clear |
| # - Dotfiles already skipped automatically | ||
| # Enable by removing the leading '# ' from the next line and editing values. | ||
| filesexcluded: .github/*, docs/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat, **/test/resources/**, *.md, *.txt | ||
| filesexcluded: .github/*, docs/*, *.md, Jenkinsfile, gradle/*, *.yml, *.gradle, gradle.properties, gradlew, gradlew.bat, **/test/resources/**, *.md, *.txt, *version, *.lock |
There was a problem hiding this comment.
filesexcluded conflicts with the rules documented just above it ("Simple * wildcard only (no recursive **)") but still includes a recursive **/test/resources/** pattern. It also includes duplicate entries (e.g., *.md appears twice). Consider rewriting the exclusions to only use supported wildcards and removing duplicates so it's clear what the config is actually doing.
Suggested change
| filesexcluded: .github/*, docs/*, *.md, Jenkinsfile, gradle/*, *.yml, *.gradle, gradle.properties, gradlew, gradlew.bat, **/test/resources/**, *.md, *.txt, *version, *.lock | |
| filesexcluded: .github/*, docs/*, *.md, Jenkinsfile, gradle/*, *.yml, *.gradle, gradle.properties, gradlew, gradlew.bat, test/resources/*, *.txt, *version, *.lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.