-
Notifications
You must be signed in to change notification settings - Fork 24
MLE-25780 Ruby docs updates #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,8 +1,10 @@ | ||||||
| # Sample workflow for building and deploying a Jekyll site to GitHub Pages | ||||||
| name: Deploy Jekyll with GitHub Pages dependencies preinstalled | ||||||
| # Started with: https://github.com/actions/starter-workflows/blob/main/pages/jekyll.yml . | ||||||
| # Have to use a custom Jekyll workflow as the default GitHub Jekyll workflow does not whitelist the | ||||||
| # "jekyll-tabs" plugin that lets us show code tabs in the documentation. | ||||||
|
|
||||||
| name: Deploy Jekyll site to Pages | ||||||
|
|
||||||
| on: | ||||||
| # Runs on pushes targeting the default branch | ||||||
| push: | ||||||
| branches: ["master"] | ||||||
|
|
||||||
|
|
@@ -21,23 +23,33 @@ concurrency: | |||||
| cancel-in-progress: true | ||||||
|
|
||||||
| jobs: | ||||||
| # Build job | ||||||
| build: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Checkout | ||||||
| uses: actions/checkout@v3 | ||||||
| uses: actions/checkout@v4 | ||||||
| - name: Setup Ruby and install Gemfile bundles | ||||||
| uses: ruby/setup-ruby@v1 | ||||||
| with: | ||||||
| ruby-version: '3.3.4' # Matches GH Pages; keep explicit to match .ruby-version and make CI intent clear | ||||||
|
||||||
| ruby-version: '3.3.4' # Matches GH Pages; keep explicit to match .ruby-version and make CI intent clear | |
| ruby-version: '3.3.4' # Matches GH Pages; keep explicit to make CI intent clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filesexcludedconflicts with the rules documented just above it ("Simple * wildcard only (no recursive **)") but still includes a recursive**/test/resources/**pattern. It also includes duplicate entries (e.g.,*.mdappears twice). Consider rewriting the exclusions to only use supported wildcards and removing duplicates so it's clear what the config is actually doing.