MLE-23744 implement optic fromDocs in node client #1049
+566
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
stevebio
force-pushed
the
feature/23744-implement-fromDocs
branch
from
103b445 to
e0da9e3
Compare
rjrudin
reviewed
Jan 7, 2026
stevebio
force-pushed
the
feature/23744-implement-fromDocs
branch
4 times, most recently
from
a671f30 to
f3f1984
Compare
Add tweaked auto-generated functions and classes for optic fromDocs plan builder. Modify PlanColumnBuilder by adding PlanColumnBuilderBase to allow chaining during column definitions. This follows the patch builder pattern. Move transitiveClosure function after annTopK to match auto-generated code and make diff easier.
stevebio
force-pushed
the
feature/23744-implement-fromDocs
branch
from
f3f1984 to
7cdc2ce
Compare
Collaborator
Author
|
One pattern breaker: I added "types.Node" as a new additional param type for the vector() function. This matches other functions like op.xs.decimal in that they can accept an xpath result node. This supports an optic pattern like this that seems vital for the node client within fromDocs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tweaked auto-generated functions and classes for optic fromDocs plan builder. Modify PlanColumnBuilder by adding PlanColumnBuilderBase to allow chaining during column definitions. This follows the patch builder pattern. Move transitiveClosure function after annTopK to match auto-generated code and make diff easier.