MLE-24397 - fix reported issue on Linux FIPS around exception caused by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place. #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project to lib/www-authenticate-patched, and fix in place. Changes to www-authenticate-patched include: removal of unnecessary pre-load of MD5 digester function from www-authenticate and md5 js files, use of Buffer.from rather than new Buffer (deprecated), and moving a prototype decl to after function has been defined. Add Progress copyright and typedef comment to Authenticator.
stevebio
requested review from
BillFarber,
anu3990 and
rjrudin
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a FIPS compliance issue on Linux where the default loading of MD5 digest algorithm was causing exceptions. The solution incorporates source code from the abandoned www-authenticate project and patches it in place to avoid MD5 loading issues.
Key changes:
- Updates all require paths from
www-authenticatetowww-authenticate-patched - Adds a blank line to the beginning of the patched www-authenticate.js file
- Updates test file to reference the new patched module location
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-basic/digestauth-fips-nomd5load.js | Updates test to use patched www-authenticate module paths |
| lib/www-authenticate-patched/www-authenticate.js | Adds blank line at beginning of patched authentication module |
| lib/requester.js | Changes require path to use patched www-authenticate module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Adding a blank line at the beginning of the file serves no functional purpose and reduces code quality. Consider removing this unnecessary whitespace.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLE-24397 - fix reported issue on Linux FIPS around exception caused by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place.