Skip to content

MLE-24397 - fix reported issue on Linux FIPS around exception caused by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place. #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

MLE-24397 - fix reported issue on Linux FIPS around exception caused by default load of FIPS-forbidden MD5 digest algorithm. Incorporate the source from the abandoned www-authenticate project and fix in place. #964

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1befbc
Remove fixed files, will re-create with commits to show changes.
stevebio Sep 22, 2025
3a5f3fc
Add pre-fix files from www-authenticate to folder www-authenticate-pa…
stevebio Sep 22, 2025
cc32ad6
MLE-24397 - fix reported issue on Linux FIPS around exception caused …
stevebio Sep 22, 2025
b16d9f2
Merge branch 'develop' into task/fipsMd5Fix
stevebio Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/requester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Copyright © 2015-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
*/
'use strict';
var createAuthInitializer = require('./www-authenticate/www-authenticate');
var createAuthInitializer = require('./www-authenticate-patched/www-authenticate');
var Kerberos = require('./optional.js')
.libraryProperty('kerberos', 'Kerberos');
var Multipart = require('multipart-stream');
Expand Down
0 lib/www-authenticate/md5.js → lib/www-authenticate-patched/md5.js
View file
Open in desktop
File renamed without changes.
0 lib/www-authenticate/parsers.js → lib/www-authenticate-patched/parsers.js
View file
Open in desktop
File renamed without changes.
0 lib/www-authenticate/user-credentials.js → ...-authenticate-patched/user-credentials.js
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions lib/www-authenticate/www-authenticate.js → ...-authenticate-patched/www-authenticate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a blank line at the beginning of the file serves no functional purpose and reduces code quality. Consider removing this unnecessary whitespace.

Suggested change

Copilot uses AI. Check for mistakes.
/*
* www-authenticate
* https://github.com/randymized/www-authenticate
Expand All @@ -7,8 +8,8 @@
*/

/*
* Copyright © 2015-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
*/
* Copyright © 2015-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
*/

'use strict';

Expand Down
8 changes: 4 additions & 4 deletions test-basic/digestauth-fips-nomd5load.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ describe('FIPS test - ensure MD5 hash digester object is not loaded by default o
* To simulate the require/load, we first delete the module from Node's require cache
* and then require it again, which forces a reload of the module.
*/
delete require.cache[require.resolve('../lib/www-authenticate/www-authenticate')];
delete require.cache[require.resolve('../lib/www-authenticate/md5')];
delete require.cache[require.resolve('../lib/www-authenticate-patched/www-authenticate')];
delete require.cache[require.resolve('../lib/www-authenticate-patched/md5')];
const crypto = require('crypto');
const originalCreateHash = crypto.createHash;

Expand All @@ -40,8 +40,8 @@ describe('FIPS test - ensure MD5 hash digester object is not loaded by default o
(() => crypto.createHash('md5')).should.throw('FIPS emulation: MD5 digest algorithm is not allowed on this system!');

// Require the module - should not call to get MD5 digester so should not throw
(() => require('../lib/www-authenticate/md5')).should.not.throw();
(() => require('../lib/www-authenticate/www-authenticate')).should.not.throw();
(() => require('../lib/www-authenticate-patched/md5')).should.not.throw();
(() => require('../lib/www-authenticate-patched/www-authenticate')).should.not.throw();

} finally {
// Restore the original createHash function to avoid side effects
Expand Down