Merged
Conversation
Contributor
Author
|
Question: should we update the |
slax57
requested changes
Apr 14, 2025
Contributor
slax57
left a comment
There was a problem hiding this comment.
Other than that I found no issues while testing, well done!
Regarding your question about create-react-admin, yes I believe we should update the version in the templates (but please in another PR, this one's already big enough 😅 )
packages/ra-ui-materialui/src/button/BulkDeleteWithUndoButton.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
slax57
approved these changes
Apr 16, 2025
slax57
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MUI v7 is out.
Solution
Follow #10655
How To Test
make run-demoand compare it with https://marmelab.com/react-admin-demoCssVariablestheme in the demomake run-tutorialTo make sure the demo builds despite the
@ts-expect-errorhere:create-react-adminbut targets MUIv7:node_modulesAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature