Skip to content

Add support for defaultProps override via theme#10655

Merged
slax57 merged 17 commits intonextfrom
improve-theme-dx
Apr 14, 2025
Merged

Add support for defaultProps override via theme#10655
slax57 merged 17 commits intonextfrom
improve-theme-dx

Conversation

@djhi
Copy link
Contributor

@djhi djhi commented Apr 10, 2025 •
edited
Loading

Problem

  • Our components does not leverage MUI types for themes
  • Our components don't support defaultProps override from themes

Solution

  • Ensure all components augment MUI Theme types
  • Ensure all components support defaultProps override from themes

How To Test

  • Run the demos and compare them with production

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The documentation is up to date

djhi added 10 commits April 10, 2025 11:40
@djhi djhi added the WIP Work In Progress label Apr 10, 2025
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Apr 10, 2025
@djhi djhi mentioned this pull request Apr 11, 2025
Merged
4 tasks
@slax57 slax57 requested a review from Copilot April 11, 2025 13:53
Copilot AI reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 116 out of 116 changed files in this pull request and generated no comments.

@slax57 slax57 self-requested a review April 14, 2025 09:23
slax57
slax57 requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge! Incredible work! 💪 💪 💪

@slax57 slax57 added this to the 5.8.0 milestone Apr 14, 2025
@slax57 slax57 merged commit 983d257 into next Apr 14, 2025
16 checks passed
@slax57 slax57 deleted the improve-theme-dx branch April 14, 2025 14:07
@slax57 slax57 changed the title Improve theme dx Improve theme DX Apr 14, 2025
@fzaninotto fzaninotto changed the title Improve theme DX Add support for defaultProps override via theme Apr 16, 2025
@fzaninotto fzaninotto mentioned this pull request May 5, 2025
Closed
@Madeorsk Madeorsk mentioned this pull request Jun 9, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@slax57 slax57 slax57 approved these changes

Assignees

No one assigned

Labels

RFR Ready For Review

Milestone

5.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@djhi @slax57