Skip to content

Do OOP Basic#2518

Open
Sviat-Holov wants to merge 6 commits intomate-academy:masterfrom
Sviat-Holov:master
Open

Do OOP Basic#2518
Sviat-Holov wants to merge 6 commits intomate-academy:masterfrom
Sviat-Holov:master

Conversation

@Sviat-Holov
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! I am approving your solution as it meets all the functional requirements perfectly. You've done a great job implementing the abstract Machine class, creating the subclasses, and demonstrating polymorphism in the MainApp class.

As a minor suggestion for future improvement, you could refine the grammar in your console output messages. For instance, changing "Excavator is started work." to "Excavator started working." would sound more natural. This is not a functional issue, but it's a good practice for creating clear and professional user-facing text. Keep up the great coding!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator is started work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message "Excavator is started work." is a bit unnatural in English. For better readability, consider changing it to "Excavator has started work." or "Excavator started working."


@Override
public void stopWork() {
System.out.println("Excavator is stopped work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task description requires a message indicating the machine "stopped working". The current message "Excavator is stopped work." doesn't quite match. Please update it to something like "Excavator stopped working."

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer is started work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing 'is started work' is a bit unnatural in English. Consider rephrasing this to something like 'Bulldozer started to work.' or 'Bulldozer has started its work.' for better clarity.


@Override
public void stopWork() {
System.out.println("Bulldozer is stopped working.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing 'is stopped working' is also a bit awkward. A more common way to say this would be 'Bulldozer has stopped working.' or 'Bulldozer stopped working.'

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck is started work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is grammatically a bit awkward. A more natural phrasing in English would be "Truck started working." or "Truck has started its work."


@Override
public void stopWork() {
System.out.println("Truck is stopped work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the doWork method, this message could be phrased more naturally. The task requires a message that the machine "stopped working". A better alternative would be "Truck stopped working."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants