Skip to content

Do OOP Basic #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sviat-Holov wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Do OOP Basic #2518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bad9184
create class Machine.
Sviat-Holov Jan 27, 2026
f981fa3
create class Bulldozer.
Sviat-Holov Jan 27, 2026
ea02aac
create class Excavator.
Sviat-Holov Jan 27, 2026
b0d3b01
create class Truck.
Sviat-Holov Jan 27, 2026
d05667b
create a Machine array.
Sviat-Holov Jan 27, 2026
8231e64
create a Machine array with loop for each.
Sviat-Holov Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer is started work.");
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing 'is started work' is a bit unnatural in English. Consider rephrasing this to something like 'Bulldozer started to work.' or 'Bulldozer has started its work.' for better clarity.

}

@Override
public void stopWork() {
System.out.println("Bulldozer is stopped working.");
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing 'is stopped working' is also a bit awkward. A more common way to say this would be 'Bulldozer has stopped working.' or 'Bulldozer stopped working.'

}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator is started work.");
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message "Excavator is started work." is a bit unnatural in English. For better readability, consider changing it to "Excavator has started work." or "Excavator started working."

}

@Override
public void stopWork() {
System.out.println("Excavator is stopped work.");
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task description requires a message indicating the machine "stopped working". The current message "Excavator is stopped work." doesn't quite match. Please update it to something like "Excavator stopped working."

}
}
8 changes: 8 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package core.basesyntax;

public abstract class Machine {

public abstract void doWork();

public abstract void stopWork();
}
8 changes: 7 additions & 1 deletion src/main/java/core/basesyntax/MainApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
package core.basesyntax;

public class MainApp {

public static void main(String[] args) {
Machine[] machines = {new Truck(), new Bulldozer(), new Excavator()};
for (Machine machine : machines) {
machine.doWork();
machine.stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck is started work.");
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is grammatically a bit awkward. A more natural phrasing in English would be "Truck started working." or "Truck has started its work."

}

@Override
public void stopWork() {
System.out.println("Truck is stopped work.");
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the doWork method, this message could be phrased more naturally. The task requires a message that the machine "stopped working". A better alternative would be "Truck stopped working."

}
}