feat: appstore #45

sockeye-d · 2026-01-27T08:11:14Z

Adds a new appstore UI, allowing users to search for, download, and install apps from either the Rebble Web Services appstore API or Core Devices appstore API. Installed apps are then checked for updates with a background service and a notification is generated when an app is updatable.

This also upgrades material3 to an alpha version for floating action button menus, which may be able to be replaced if this is undesirable.

…ctionButtonMenu, change installation flow slightly to use said FAB

… :appstore:ui

…ay Chalk screenshots

gradle/wrapper/gradle-wrapper.properties

github-actions · 2026-01-27T09:23:57Z

Lint report

Results

[ERROR] [detekt.compiler.CompilerWarning] [HELP LINK] Kotlin compiler warning: SENSELESS\_COMPARISON
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in d181fd4
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in d181fd4
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in d181fd4
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in d181fd4
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in d181fd4
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in d181fd4
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in d181fd4
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in d181fd4
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in d181fd4
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in d181fd4
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in d181fd4
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in d181fd4
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in d181fd4
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in d181fd4
  
  screenWrapper = { _, screen ->
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 244 in d181fd4
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 290 in d181fd4
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 170 in d181fd4
  
  is Outcome.Success if appInstallState.data == AppInstallState.INCOMPATIBLE -> installApp
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 171 in d181fd4
  
  is Outcome.Success if appInstallState.data == AppInstallState.INSTALLED -> uninstallApp
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 202 in d181fd4
  
  for (source in appstoreSources.filter { it.enabled }) {

[ERROR] [detekt.kotlinovanavigation.NavigationKeyNoEnums] [HELP LINK] Screen key AppstoreDetailsScreenKey -> Application has Enum parameter 'type'.

microPebble/common-navigation/src/main/kotlin/com/matejdro/micropebble/navigation/keys/AppstoreDetailsScreenKey.kt

Lines 11 to 19 in d181fd4

    
           @Parcelize 
        
           @TypeParceler<Application, ApplicationParceler> 
        
           @TypeParceler<AppstoreSource?, AppstoreSourceParceler> 
        
           data class AppstoreDetailsScreenKey( 
        
              val app: Application, 
        
              val onlyPartialData: Boolean, 
        
              val appstoreSource: AppstoreSource? = null, 
        
              val platformFilter: String? = null, 
        
           ) : BaseScreenKey()

[ERROR] [detekt.coroutines.SuspendFunSwallowedCancellation] [HELP LINK] The runCatchinghas suspend call inside. You should either use specifictry-catchonly catching exception that you are expecting or rethrow theCancellationException if already caught.
- microPebble/apps/ui/src/main/kotlin/com/matejdro/micropebble/apps/ui/list/WatchappListViewModel.kt
  
  Line 239 in d181fd4
  
  runCatching {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 149 in d181fd4
  
  runCatching {
[ERROR] [detekt.style.UseOrEmpty] [HELP LINK] This '?: emptyList' can be replaced with 'orEmpty' call
- microPebble/appstore/api/src/main/kotlin/com/matejdro/micropebble/appstore/api/store/application/AlgoliaApplication.kt
  
  Line 49 in d181fd4
  
  capabilities = capabilities ?: emptyList(),
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 293 in d181fd4
  
  var url by remember { mutableStateOf(source?.url ?: "") }
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 295 in d181fd4
  
  var algoliaAppId by remember { mutableStateOf(source?.algoliaData?.appId ?: "") }
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 296 in d181fd4
  
  var algoliaApiKey by remember { mutableStateOf(source?.algoliaData?.apiKey ?: "") }
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 297 in d181fd4
  
  var algoliaIndexName by remember { mutableStateOf(source?.algoliaData?.indexName ?: "") }
[ERROR] [detekt.coroutines.InjectDispatcher] [HELP LINK] Dispatcher IO is used without dependency injection.
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/ApiClientImpl.kt
  
  Line 23 in d181fd4
  
  runBlocking(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppstoreSourceServiceImpl.kt
  
  Line 34 in d181fd4
  
  override suspend fun writeTo(t: List<AppstoreSource>, output: OutputStream) = withContext(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 54 in d181fd4
  
  override suspend fun writeTo(t: Map<Uuid, AppInstallSource>, output: OutputStream) = withContext(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 71 in d181fd4
  
  withContext(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 103 in d181fd4
  
  override suspend fun uninstall(uuid: Uuid) = withContext(Dispatchers.IO) {
[ERROR] [detekt.naming.NoNameShadowing] [HELP LINK] Name shadowed: platform
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 244 in d181fd4
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 290 in d181fd4
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 202 in d181fd4
  
  for (source in appstoreSources.filter { it.enabled }) {
[ERROR] [detekt.potential-bugs.NullableToStringCall] [HELP LINK] This call '$platformFilter?.isCircular\($\).toString' may return the string "null".
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 182 in d181fd4
  
  logcat { (platformFilter?.isCircular()).toString() }
[ERROR] [detekt.style.UnusedImports] [HELP LINK] The import 'kotlinx.serialization.json.decodeFromJsonElement' is unused.
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreViewModel.kt
  
  Line 33 in d181fd4
  
  import kotlinx.serialization.json.decodeFromJsonElement
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 18 in d181fd4
  
  import androidx.compose.foundation.lazy.staggeredgrid.items

Suppressed Results

Nothing here.

Lint report

Results

[WARNING] [ModifierParameter] Optional Modifier parameter should have a default value of Modifier
- microPebble/common-compose/src/main/kotlin/com/matejdro/micropebble/ui/errors/NoSourcesDisplay.kt
  
  Line 22 in d181fd4
  
  modifier: Modifier = Modifier.padding(horizontal = 16.dp),
- microPebble/common-compose/src/main/kotlin/com/matejdro/micropebble/ui/errors/NoSourcesDisplay.kt
  
  Line 22 in d181fd4
  
  modifier: Modifier = Modifier.padding(horizontal = 16.dp),
[ERROR] [UnusedMaterial3ScaffoldPaddingParameter] Content padding parameter \_ is not used
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 201 in d181fd4
  
  }) { _ ->
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 201 in d181fd4
  
  }) { _ ->
[WARNING] [PluralsCandidate] Formatting %d followed by words $"apps"$: This should probably be a plural rather than a string
- microPebble/appstore/data/src/main/res/values/strings.xml
  
  Line 6 in d181fd4
  
  <string name="apps_have_updates">%1$d apps have updates</string>
- microPebble/appstore/data/src/main/res/values/strings.xml
  
  Line 6 in d181fd4
  
  <string name="apps_have_updates">%1$d apps have updates</string>

[WARNING] [UnusedResources] The resource R.drawable.ic\_appstore\_source\_disabled appears to be unused

microPebble/appstore/ui/src/main/res/drawable/ic_appstore_source_disabled.xml

Lines 1 to 5 in d181fd4

    
           <vector xmlns:android="http://schemas.android.com/apk/res/android" android:autoMirrored="true" android:height="24dp" android:tint="#000000" android:viewportHeight="960" android:viewportWidth="960" android:width="24dp"> 
        
               <path android:fillColor="@android:color/white" android:pathData="M446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514ZM552,419L552,419Q552,419 552,419Q552,419 552,419L552,419Q552,419 552,419Q552,419 552,419ZM446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514ZM552,419L552,419Q552,419 552,419Q552,419 552,419L552,419Q552,419 552,419Q552,419 552,419ZM446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514ZM552,419L552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419ZM791,904L56,169L112,112L848,848L791,904ZM480,840Q329,840 224.5,793.5Q120,747 120,680L120,280Q120,254 137.5,230.5Q155,207 187,187L439,439Q367,436 306,421Q245,406 200,381L200,501Q251,530 323,545Q395,560 480,560Q500,560 519,559.5Q538,559 557,557L627,627Q593,634 556,637Q519,640 480,640Q395,640 323,625Q251,610 200,581L200,680Q209,709 297.5,734.5Q386,760 480,760Q544,760 608.5,747Q673,734 715,715L773,773Q724,804 647.5,822Q571,840 480,840ZM830,717L760,647L760,581Q749,587 738,592Q727,597 715,602L654,541Q684,533 710.5,523.5Q737,514 760,501L760,381Q719,404 666,418Q613,432 550,437L474,361Q518,361 566,354Q614,347 655.5,335.5Q697,324 725.5,309.5Q754,295 760,281Q749,252 659.5,226Q570,200 480,200Q443,200 404.5,205Q366,210 331,218L265,152Q310,137 365,128.5Q420,120 480,120Q629,120 734.5,167Q840,214 840,280L840,680Q840,690 837.5,699Q835,708 830,717Z"/> 
        
           </vector>

microPebble/appstore/ui/src/main/res/drawable/ic_chevron_backward.xml

Lines 1 to 5 in d181fd4

    
           <vector xmlns:android="http://schemas.android.com/apk/res/android" android:autoMirrored="true" android:height="24dp" android:tint="#000000" android:viewportHeight="960" android:viewportWidth="960" android:width="24dp"> 
        
               <path android:fillColor="@android:color/white" android:pathData="M560,720L320,480L560,240L616,296L432,480L616,664L560,720Z"/> 
        
           </vector>

microPebble/shared-resources/src/main/res/drawable/ic_hardware_gabbro.xml

Lines 1 to 30 in d181fd4

    
           <vector xmlns:android="http://schemas.android.com/apk/res/android" xmlns:aapt="http://schemas.android.com/aapt" 
        
               android:viewportWidth="24" 
        
               android:viewportHeight="24" 
        
               android:width="24dp" 
        
               android:height="24dp"> 
        
               <path 
        
                   android:pathData="M18.5 12A6.5 6.5 0 0 1 5.5 12A6.5 6.5 0 0 1 18.5 12Z" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M20.5 12A8.5 8.5 0 0 1 3.5 12A8.5 8.5 0 0 1 20.5 12Z" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M17.5 18.5V21.5h-2v-1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M6.5 18.5V21.5h2v-1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M6.5 5.5V2.5h2v1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M17.5 5.5V2.5h-2v1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
           </vector>

microPebble/appstore/ui/src/main/res/values/strings.xml

Line 11 in d181fd4

<string name="appDiscourseLink">Discuss on Discourse</string>
microPebble/appstore/ui/src/main/res/values/strings.xml

Line 14 in d181fd4

<string name="save">Save</string>
microPebble/appstore/ui/src/main/res/values/strings.xml

Line 24 in d181fd4

<string name="installing">Installing</string>
microPebble/appstore/ui/src/main/res/values/strings.xml

Line 31 in d181fd4

<string name="unoffical_compatibility_info_header">Unofficially supported compatibility</string>

Suppressed Results

Nothing here.

github-actions · 2026-01-27T11:19:34Z

Lint report

Results

[ERROR] [detekt.compiler.CompilerWarning] [HELP LINK] Kotlin compiler warning: SENSELESS\_COMPARISON
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in 9a3203d
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in 9a3203d
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in 9a3203d
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in 9a3203d
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in 9a3203d
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in 9a3203d
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in 9a3203d
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in 9a3203d
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in 9a3203d
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in 9a3203d
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in 9a3203d
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in 9a3203d
  
  screenWrapper = { _, screen ->
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 98 in 9a3203d
  
  val overridenInitialHistoryFromDeepLink = if (deepLinkTarget != null) {
- microPebble/app/src/main/kotlin/com/matejdro/micropebble/MainActivity.kt
  
  Line 127 in 9a3203d
  
  screenWrapper = { _, screen ->
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 244 in 9a3203d
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 290 in 9a3203d
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 170 in 9a3203d
  
  is Outcome.Success if appInstallState.data == AppInstallState.INCOMPATIBLE -> installApp
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 171 in 9a3203d
  
  is Outcome.Success if appInstallState.data == AppInstallState.INSTALLED -> uninstallApp
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 202 in 9a3203d
  
  for (source in appstoreSources.filter { it.enabled }) {
[ERROR] [detekt.coroutines.SuspendFunSwallowedCancellation] [HELP LINK] The runCatchinghas suspend call inside. You should either use specifictry-catchonly catching exception that you are expecting or rethrow theCancellationException if already caught.
- microPebble/apps/ui/src/main/kotlin/com/matejdro/micropebble/apps/ui/list/WatchappListViewModel.kt
  
  Line 239 in 9a3203d
  
  runCatching {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 149 in 9a3203d
  
  runCatching {
[ERROR] [detekt.style.UseOrEmpty] [HELP LINK] This '?: emptyList' can be replaced with 'orEmpty' call
- microPebble/appstore/api/src/main/kotlin/com/matejdro/micropebble/appstore/api/store/application/AlgoliaApplication.kt
  
  Line 49 in 9a3203d
  
  capabilities = capabilities ?: emptyList(),
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 293 in 9a3203d
  
  var url by remember { mutableStateOf(source?.url ?: "") }
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 295 in 9a3203d
  
  var algoliaAppId by remember { mutableStateOf(source?.algoliaData?.appId ?: "") }
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 296 in 9a3203d
  
  var algoliaApiKey by remember { mutableStateOf(source?.algoliaData?.apiKey ?: "") }
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/sources/AppstoreSourcesScreen.kt
  
  Line 297 in 9a3203d
  
  var algoliaIndexName by remember { mutableStateOf(source?.algoliaData?.indexName ?: "") }
[ERROR] [detekt.coroutines.InjectDispatcher] [HELP LINK] Dispatcher IO is used without dependency injection.
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/ApiClientImpl.kt
  
  Line 23 in 9a3203d
  
  runBlocking(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppstoreSourceServiceImpl.kt
  
  Line 34 in 9a3203d
  
  override suspend fun writeTo(t: List<AppstoreSource>, output: OutputStream) = withContext(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 54 in 9a3203d
  
  override suspend fun writeTo(t: Map<Uuid, AppInstallSource>, output: OutputStream) = withContext(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 71 in 9a3203d
  
  withContext(Dispatchers.IO) {
- microPebble/appstore/data/src/main/kotlin/com/matejdro/micropebble/appstore/data/AppInstallationClientImpl.kt
  
  Line 103 in 9a3203d
  
  override suspend fun uninstall(uuid: Uuid) = withContext(Dispatchers.IO) {
[ERROR] [detekt.naming.NoNameShadowing] [HELP LINK] Name shadowed: platform
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 244 in 9a3203d
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 290 in 9a3203d
  
  for ((platform, compatibility) in app.compatibility - "android" - "ios") {
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 202 in 9a3203d
  
  for (source in appstoreSources.filter { it.enabled }) {
[ERROR] [detekt.potential-bugs.NullableToStringCall] [HELP LINK] This call '$platformFilter?.isCircular\($\).toString' may return the string "null".
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 182 in 9a3203d
  
  logcat { (platformFilter?.isCircular()).toString() }
[ERROR] [detekt.style.UnusedImports] [HELP LINK] The import 'kotlinx.serialization.json.decodeFromJsonElement' is unused.
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreViewModel.kt
  
  Line 33 in 9a3203d
  
  import kotlinx.serialization.json.decodeFromJsonElement
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt
  
  Line 18 in 9a3203d
  
  import androidx.compose.foundation.lazy.staggeredgrid.items

Suppressed Results

Nothing here.

Lint report

Results

[WARNING] [ModifierParameter] Optional Modifier parameter should have a default value of Modifier
- microPebble/common-compose/src/main/kotlin/com/matejdro/micropebble/ui/errors/NoSourcesDisplay.kt
  
  Line 22 in 9a3203d
  
  modifier: Modifier = Modifier.padding(horizontal = 16.dp),
- microPebble/common-compose/src/main/kotlin/com/matejdro/micropebble/ui/errors/NoSourcesDisplay.kt
  
  Line 22 in 9a3203d
  
  modifier: Modifier = Modifier.padding(horizontal = 16.dp),
[ERROR] [UnusedMaterial3ScaffoldPaddingParameter] Content padding parameter \_ is not used
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 201 in 9a3203d
  
  }) { _ ->
- microPebble/appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt
  
  Line 201 in 9a3203d
  
  }) { _ ->
[WARNING] [PluralsCandidate] Formatting %d followed by words $"apps"$: This should probably be a plural rather than a string
- microPebble/appstore/data/src/main/res/values/strings.xml
  
  Line 6 in 9a3203d
  
  <string name="apps_have_updates">%1$d apps have updates</string>
- microPebble/appstore/data/src/main/res/values/strings.xml
  
  Line 6 in 9a3203d
  
  <string name="apps_have_updates">%1$d apps have updates</string>

[WARNING] [UnusedResources] The resource R.drawable.ic\_appstore\_source\_disabled appears to be unused

microPebble/appstore/ui/src/main/res/drawable/ic_appstore_source_disabled.xml

Lines 1 to 5 in 9a3203d

    
           <vector xmlns:android="http://schemas.android.com/apk/res/android" android:autoMirrored="true" android:height="24dp" android:tint="#000000" android:viewportHeight="960" android:viewportWidth="960" android:width="24dp"> 
        
               <path android:fillColor="@android:color/white" android:pathData="M446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514ZM552,419L552,419Q552,419 552,419Q552,419 552,419L552,419Q552,419 552,419Q552,419 552,419ZM446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514L446,514Q446,514 446,514Q446,514 446,514ZM552,419L552,419Q552,419 552,419Q552,419 552,419L552,419Q552,419 552,419Q552,419 552,419ZM446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514Q446,514 446,514ZM552,419L552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419Q552,419 552,419ZM791,904L56,169L112,112L848,848L791,904ZM480,840Q329,840 224.5,793.5Q120,747 120,680L120,280Q120,254 137.5,230.5Q155,207 187,187L439,439Q367,436 306,421Q245,406 200,381L200,501Q251,530 323,545Q395,560 480,560Q500,560 519,559.5Q538,559 557,557L627,627Q593,634 556,637Q519,640 480,640Q395,640 323,625Q251,610 200,581L200,680Q209,709 297.5,734.5Q386,760 480,760Q544,760 608.5,747Q673,734 715,715L773,773Q724,804 647.5,822Q571,840 480,840ZM830,717L760,647L760,581Q749,587 738,592Q727,597 715,602L654,541Q684,533 710.5,523.5Q737,514 760,501L760,381Q719,404 666,418Q613,432 550,437L474,361Q518,361 566,354Q614,347 655.5,335.5Q697,324 725.5,309.5Q754,295 760,281Q749,252 659.5,226Q570,200 480,200Q443,200 404.5,205Q366,210 331,218L265,152Q310,137 365,128.5Q420,120 480,120Q629,120 734.5,167Q840,214 840,280L840,680Q840,690 837.5,699Q835,708 830,717Z"/> 
        
           </vector>

microPebble/appstore/ui/src/main/res/drawable/ic_chevron_backward.xml

Lines 1 to 5 in 9a3203d

    
           <vector xmlns:android="http://schemas.android.com/apk/res/android" android:autoMirrored="true" android:height="24dp" android:tint="#000000" android:viewportHeight="960" android:viewportWidth="960" android:width="24dp"> 
        
               <path android:fillColor="@android:color/white" android:pathData="M560,720L320,480L560,240L616,296L432,480L616,664L560,720Z"/> 
        
           </vector>

microPebble/shared-resources/src/main/res/drawable/ic_hardware_gabbro.xml

Lines 1 to 30 in 9a3203d

    
           <vector xmlns:android="http://schemas.android.com/apk/res/android" xmlns:aapt="http://schemas.android.com/aapt" 
        
               android:viewportWidth="24" 
        
               android:viewportHeight="24" 
        
               android:width="24dp" 
        
               android:height="24dp"> 
        
               <path 
        
                   android:pathData="M18.5 12A6.5 6.5 0 0 1 5.5 12A6.5 6.5 0 0 1 18.5 12Z" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M20.5 12A8.5 8.5 0 0 1 3.5 12A8.5 8.5 0 0 1 20.5 12Z" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M17.5 18.5V21.5h-2v-1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M6.5 18.5V21.5h2v-1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M6.5 5.5V2.5h2v1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
               <path 
        
                   android:pathData="M17.5 5.5V2.5h-2v1.5" 
        
                   android:strokeColor="#000000" 
        
                   android:strokeWidth="1" /> 
        
           </vector>

microPebble/appstore/ui/src/main/res/values/strings.xml

Line 11 in 9a3203d

<string name="appDiscourseLink">Discuss on Discourse</string>
microPebble/appstore/ui/src/main/res/values/strings.xml

Line 14 in 9a3203d

<string name="save">Save</string>
microPebble/appstore/ui/src/main/res/values/strings.xml

Line 24 in 9a3203d

<string name="installing">Installing</string>
microPebble/appstore/ui/src/main/res/values/strings.xml

Line 31 in 9a3203d

<string name="unoffical_compatibility_info_header">Unofficially supported compatibility</string>

Suppressed Results

Nothing here.

matejdro

Thanks for the PR!

It already looks pretty good. I have made several minor comments, mostly related to the architecture. Unfortunately, because amount of added code is large, there are also quite a few comments.

matejdro · 2026-01-27T17:58:06Z

apps/ui/src/main/kotlin/com/matejdro/micropebble/apps/ui/list/WatchappListScreen.kt

 @Composable
 private fun WatchappListScreenContent(
   state: WatchappListState,
+   appStatuses: Outcome<Map<Uuid, AppStatus>>,


Instead of both of these properties being a map, I think just adding this to the WatchappListState would be much cleaner. Instead of using a LockerWrapper, we could expose our own data class, with these two properties + a reference to the LockerWrapper.

b3cbd17 should fix this, instead of doing this I moved it all into a single flow that combines private flows instead of exposing them directly to the screen.

Hm, there is still appInstallSources. Ideally, all of this should be exposed directly in the state, without any maps.

apps/ui/src/main/kotlin/com/matejdro/micropebble/apps/ui/list/WatchappListScreen.kt

matejdro · 2026-01-27T18:15:05Z

...ompose/src/main/kotlin/com/matejdro/micropebble/ui/components/BasicExposedDropdownMenuBox.kt

+import androidx.compose.runtime.setValue
+import androidx.compose.ui.Modifier
+
+@Suppress("ModifierNotUsedAtRoot") // ExposedDropdownMenuBox is weird


Commenting suppressions 👍

matejdro · 2026-01-27T18:16:12Z

common-compose/src/main/kotlin/com/matejdro/micropebble/ui/errors/NoSourcesDisplay.kt

+import com.matejdro.micropebble.ui.R
+
+@Composable
+fun NoSourcesDisplay(


This one is only needed in the appstore module. Is there a reason it's in the common module?

appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreScreen.kt

appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsViewModel.kt

matejdro · 2026-01-27T19:40:50Z

appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsViewModel.kt

+      actionLogger.logAction { "AppstoreDetailsViewModel.onServiceRegistered()" }
+
+      resources.launchResourceControlTask(_appState) {
+         emit(Outcome.Progress())


Nit: this is unnecessary, launchResourceControlTask will automatically emit progress at the start. Same for the functions below

matejdro · 2026-01-27T19:45:26Z

appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreCollectionViewModel.kt

+   private val actionLogger: ActionLogger,
+   private val api: ApiClient,
+) : SingleScreenViewModel<AppstoreCollectionScreenKey>(resources.scope) {
+   val platform by lazy { key.platformFilter?.let { WatchType.fromCodename(it) } }


Please do not return any data from non-flow values in the ViewModel.

All ViewModel -> UI data should move through Flows. Can this be added to the appState?

The value never changes though, there is no state to it since the platform filter just comes from the key.

Yeah, but the idea is that everything is returned from the ViewModel via a single flow variable. That way it's easier to reason on what data exact is retrieved.

appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreCollectionViewModel.kt

matejdro · 2026-01-28T05:14:38Z

I have pushed CI improvement for the Datastore directly, as it is a pretty specific thing and it was easier than explaining (but you can check it out if you want, it ends up with pretty neat pattern, where Datastore is injected directly into constructor).

…to top

matejdro · 2026-01-29T14:03:42Z

appstore/ui/src/main/kotlin/com/matejdro/micropebble/appstore/ui/AppstoreDetailsScreen.kt

+import kotlin.time.toJavaInstant
 import com.matejdro.micropebble.sharedresources.R as sharedR

+private val LocalDateTimeFormatter = compositionLocalOf { DateTimeFormatter.ISO_INSTANT }


This actually duplicates existing si.inova.kotlinova.compose.time.LocalDateFormatter: https://github.com/inovait/kotlinova/blob/master/compose/src/main/kotlin/si/inova/kotlinova/compose/time/ComposeAndroidDateTimeFormatter.kt#L184

sockeye-d added 30 commits January 13, 2026 23:00

feat: appstore

e05e2fa

refactor(appstore): separate api, ui, and data modules

4ab358c

feat(appstore): client implementation, basic view, JSON schema objects

24ee2c3

feat(appstore): app grid with thumbnails, app and watchface categories

30116aa

feat(appstore): detail view, like and open source badges for home page

0c433a0

feat(appstore): move appstore UI around some more

d134e20

fix(appstore): suppress linter warning for unused parameter

55cd310

feat(appstore): category page, app installation

9da9281

feat(appstore): search

25390db

feat(appstore): infinite scrolling collections

b47c3d2

feat(appstore, apps): update material3 to 1.5.0-alpha17 for FloatingA…

d9dbf0c

…ctionButtonMenu, change installation flow slightly to use said FAB

feat(appstore): sources configuration

63ae5d1

fix(appstore): remove tests that aren't needed anymore

b072d5d

refactor(appstore): extract http client access and app installer from…

18a1bf6

… :appstore:ui

feat(appstore): updating indicator, appstore source tracking

f4eb3e2

feat(appstore): missing sources indicator

2e2c3fb

fix(appstore): move stuff around so that it doesn't jump around so much

5e5f7e1

feat(appstore): update button

7658f7d

fix(appstore): all apps erroneously being marked as missing updates

dd81e18

feat(appstore): preliminary code for background update reporting

842602b

Merge branch 'master' into appstore

f688caa

feat(appstore): background notification service

84c96d6

feat(appstore): background app update checking

7dd8f58

Merge branch 'master' into appstore

d79411a

fix(appstore): properly represent installation state on details page

14d0f3d

feat(appstore): make install button become uninstall button

dac29b4

refactor(appstore): move to flows for search handling, properly displ…

0d9e7dc

…ay Chalk screenshots

feat(appstore): show hardware compatibility

a235b71

feat(appstore): filter by platform

d9f4fc7

Merge branch 'master' into appstore

beadea8

fix(appstore): clean up generated files

1716ac9

matejdro reviewed Jan 27, 2026

View reviewed changes

gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved

sockeye-d force-pushed the appstore branch from 479e926 to 5692b42 Compare January 27, 2026 09:15

build: reset gradle wrapper

0b28bd1

sockeye-d force-pushed the appstore branch from 5692b42 to 0b28bd1 Compare January 27, 2026 09:15

fix(appstore): don't use enums

7645d35

matejdro added 2 commits January 27, 2026 19:55

refactor(appstore): create datastores via DI

dbcedf5

refactor(appstore): move WorkerKey to di package

25b5a18

matejdro requested changes Jan 27, 2026

View reviewed changes

matejdro and others added 6 commits January 28, 2026 06:15

refactor(appstore): use withIO

769f5e4

refactor(apps): move app updatable status into state

b3cbd17

refactor(apps): clean up previous refactoring (b3cbd17)

003f81b

refactor(appstore): extract API interaction to ApiClient

41fb06b

refactor(appstore): make http client private

318b027

refactor(appstore): move http to be a suspending function

5571993

sockeye-d force-pushed the appstore branch from f73a939 to 5571993 Compare January 28, 2026 11:08

sockeye-d added 6 commits January 28, 2026 03:38

refactor(appstore): fix dispatcher usage in installation, simplify code

362244b

refactor(appstore): use the kotlinova android datetimeformatter

9fee3da

fix: unknown watch names should result in "Unknown"

97a0756

refactor(appstore): lazy paging items are nullable now

f0a0073

fix(appstore): make UI usable on landscape by not pinning search bar …

d7ce6a3

…to top

refactor(appstore): remove mutableState from view models

32403ec

matejdro reviewed Jan 29, 2026

View reviewed changes

feat: appstore #45

Are you sure you want to change the base?

feat: appstore #45

Conversation

sockeye-d commented Jan 27, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2026

Lint report

Results

Suppressed Results

Lint report

Results

Suppressed Results

Uh oh!

github-actions bot commented Jan 27, 2026

Lint report

Results

Suppressed Results

Lint report

Results

Suppressed Results

Uh oh!

matejdro left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matejdro Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matejdro commented Jan 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matejdro Jan 29, 2026 •

edited

Loading