feat: ✨ enhance cloning so two-color icons adhere to same-palette rule#2932
Merged
PKief merged 1 commit intomaterial-extensions:mainfrom Mar 11, 2025
Merged
Conversation
PKief
approved these changes
Mar 11, 2025
Member
PKief
left a comment
There was a problem hiding this comment.
Thanks for the improvement. It looks good to me 👍
Contributor
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was working on a
migrationsfolder icon (rel: #895) by cloning thefolder-databaseand this was the result:As you can see, the color in the motif path is from the
light-bluepalette, while the chosen base color was in theblue-graypalette.I think this issue occurs due to two factors:
blue-grayandlight-bluepalettes have similar hue values, but very different saturations and luminances.Since we are only playing with the hue and luminance values of the colors, the result ends up with a color from the
light-bluepalette instead ofblue-gray.This PR ensures the saturation of the base color is maintained when selecting the motif color, so the resulting color comes from the same palette as the base color.
Contribution Guidelines