Skip to content

feat: ✨ enhance cloning so two-color icons adhere to same-palette rule #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PKief merged 1 commit into from
Mar 11, 2025
Merged

feat: ✨ enhance cloning so two-color icons adhere to same-palette rule #2932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/core/generator/clones/utils/color/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,16 @@ export const replacementMap = (baseColor: string, colors: Set<string>) => {
const color = chroma(orderedColors[i]);
let newColor = color.set('hsl.h', baseHue);

// if it's a simple, 2-color icon, we also retain the saturation
// from the base color. This helps us better adhere to the
// same-palette rule in the extension's guidelines; keeping both
// colors within the same "color column" of the material palette.
// This mainly affects folder icons, which usually have 2-color
// designs.
if (orderedColors.length === 2) {
newColor = newColor.set('hsl.s', baseColorChroma.get('hsl.s'));
}

// the idea is to keep the paths with the same relative darkness
// as the original icon, but with different hues. So if the
// new color results in a darker color (as we are looping from
Expand Down