Skip to content

fix: s/9.00/9.0/ and (input Docker image, output Docker tag) for (coqorg/coq, rocq/rocq-prover)#34

Merged
erikmd merged 3 commits intomasterfrom
fix-9.0
Apr 30, 2025
Merged

fix: s/9.00/9.0/ and (input Docker image, output Docker tag) for (coqorg/coq, rocq/rocq-prover)#34
erikmd merged 3 commits intomasterfrom
fix-9.0

Conversation

@erikmd
Copy link
Collaborator

@erikmd erikmd commented Apr 30, 2025

@erikmd erikmd self-assigned this Apr 30, 2025
@erikmd
Copy link
Collaborator Author

erikmd commented Apr 30, 2025

@hoheinzollern

Note that the automatically-generated README to be uploaded in Docker Hub at each release (cf. wiki) is available in the debrief job, namely: https://gitlab.inria.fr/math-comp/docker-mathcomp/-/jobs/5688792https://gitlab.inria.fr/math-comp/docker-mathcomp/-/jobs/5688788/artifacts/raw/generated/README.md?inline=false

I propose to look after this upload myself this time.

@erikmd
Copy link
Collaborator Author

erikmd commented Apr 30, 2025

BTW I can see in the generated README that "rocq-prover" does not appear in the tag for rocq 9.0, so this would be somewhat inconsistent with these tags: https://hub.docker.com/r/mathcomp/mathcomp-dev/tags

I'll push another commit to fix this.

With this patch:
- the tag latest-coq-8.20 is built from coqorg/coq:8.20-ocaml-4.14
- the tag latest-rocq-prover-9.0 … from rocq/rocq-prover:9.0-ocaml-4.14
@erikmd
Copy link
Collaborator Author

erikmd commented Apr 30, 2025

I pushed a commit to ensure "input/output compatibility", with "coqorg/coq:8.20" & "rocq/rocq-prover:9.0", using docker-keeper's glob-like syntax.

I updated the commented example snippet in the images.yml files so the future releases will be much easier, reusing this patch.

Now let's wait for the debrief job at https://gitlab.inria.fr/math-comp/docker-mathcomp/-/jobs/5689386

I'll merge if it succeeds.

```
mathcomp/single/Dockerfile:2 DL3006 warning: Always tag the version of an image explicitly
```

Later, we could split the Dockerfile into 2 different ones instead if need be.
@erikmd erikmd changed the title fix: s/9.00/9.0/ fix: s/9.00/9.0/ and (input Docker image, output Docker tag) for (coqorg/coq, rocq/rocq-prover) Apr 30, 2025
@erikmd erikmd merged commit 9a73ede into master Apr 30, 2025
2 checks passed
@erikmd erikmd deleted the fix-9.0 branch April 30, 2025 14:44
@erikmd
Copy link
Collaborator Author

erikmd commented Apr 30, 2025

@hoheinzollern the build is on-going:
https://gitlab.inria.fr/math-comp/docker-mathcomp/-/pipelines/1171014
and the Docker Hub README is already upgraded:
https://hub.docker.com/r/mathcomp/mathcomp#supported-tags

@hoheinzollern
Copy link
Member

@erikmd thanks for taking over. I did not fully understand the output of the pipeline failing.

@erikmd
Copy link
Collaborator Author

erikmd commented Apr 30, 2025

Hi @hoheinzollern,

the pipeline failing.

Yes I'm aware of that, see:
#35 (comment)

I can't fix it right now, but I'm taking a look again ASAP!

erikmd added a commit to rocq-community/docker-base that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants