Skip to content

Make 'Semantic Info' menu active (not sure why it was disabled)#1301

Merged
dpvc merged 2 commits intodevelopfrom
update/semantic-info
Jul 18, 2025
Merged

Make 'Semantic Info' menu active (not sure why it was disabled)#1301
dpvc merged 2 commits intodevelopfrom
update/semantic-info

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Jul 8, 2025

This PR enables the "Semantic Info" sub-menu in the "Explorer" menu. I'm not sure why it was disabled before. This fixes the attribute used for the "Prefix" selection, and adjusts the CSS for the tooltips so that the inner div has the same rounded corners as the outer container.

@dpvc dpvc requested a review from zorkow July 8, 2025 11:31
@dpvc dpvc added this to the v4.0 milestone Jul 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (4d1e195) to head (f5a9b7f).
Report is 28 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1301   +/-   ##
========================================
  Coverage    86.71%   86.71%           
========================================
  Files          337      337           
  Lines        83979    83979           
  Branches      4750     4750           
========================================
  Hits         72826    72826           
- Misses       11130    11153   +23     
+ Partials        23        0   -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Comment thread ts/ui/menu/Menu.ts
@dpvc dpvc merged commit 5ebb07d into develop Jul 18, 2025
3 checks passed
@dpvc dpvc deleted the update/semantic-info branch July 18, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants