Skip to content

Make 'Semantic Info' menu active (not sure why it was disabled) #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpvc merged 2 commits into from
Jul 18, 2025
Merged

Make 'Semantic Info' menu active (not sure why it was disabled) #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c3514f
Make 'Semantic Info' menu active (not sure why it was disabled)
dpvc Jul 8, 2025
f5a9b7f
Fix formatting
dpvc Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ts/a11y/explorer/ExplorerPool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,8 @@ const allExplorers: { [options: string]: ExplorerInit } = {
pool,
doc.explorerRegions.tooltip3,
node,
(x: HTMLElement) => x.hasAttribute('data-semantic-prefix'),
(x: HTMLElement) => x.getAttribute('data-semantic-prefix')
(x: HTMLElement) => x.hasAttribute?.('data-semantic-prefix-none'),
(x: HTMLElement) => x.getAttribute?.('data-semantic-prefix-none')
),
flame: (
doc: ExplorerMathDocument,
Expand Down
6 changes: 5 additions & 1 deletion ts/a11y/explorer/Region.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,14 +323,18 @@ export class ToolTip extends StringRegion {
height: 'auto',
opacity: 1,
'text-align': 'center',
'border-radius': '6px',
'border-radius': '4px',
padding: 0,
'border-bottom': '1px dotted black',
position: 'absolute',
display: 'inline-block',
'background-color': 'white',
'z-index': 202,
},
['.' + ToolTip.className + ' > div']: {
'border-radius': 'inherit',
padding: '0 2px',
},
});
}

Expand Down
15 changes: 5 additions & 10 deletions ts/ui/menu/Menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,16 +823,11 @@ export class Menu {
['500%'],
]),
]),
this.submenu(
'Semantic Info',
'Semantic Info',
[
this.checkbox('Type', 'Type', 'infoType'),
this.checkbox('Role', 'Role', 'infoRole'),
this.checkbox('Prefix', 'Prefix', 'infoPrefix'),
],
true
),
this.submenu('Semantic Info', 'Semantic Info', [
this.checkbox('Type', 'Type', 'infoType'),
this.checkbox('Role', 'Role', 'infoRole'),
this.checkbox('Prefix', 'Prefix', 'infoPrefix'),
]),
Comment thread
dpvc marked this conversation as resolved.
this.rule(),
this.submenu('Role Description', 'Describe math as', [
this.radioGroup('roleDescription', [
Expand Down