-
Notifications
You must be signed in to change notification settings - Fork 233
Make assistive-mml unset speech/braille and vice-versa #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1388 +/- ##
========================================
Coverage 86.49% 86.49%
========================================
Files 340 340
Lines 85813 85813
Branches 4815 4815
========================================
Hits 74220 74220
Misses 11593 11593 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are using it already in 4 places, would it make sense to move the pretend we're loading hack into a separate method like
function withoutRerendering(exec: () => void) {
Math.loading++;
exec();
Math.loading--;
}|
I've added the function you requested (I had meant to do something like that and forgot). I also added some text to the help dialog indicating the new menu behavior. |
zorkow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
This PR adjusts the menu items for speech/Braille and hidden MathML so that selecting hidden MathML will turn off speech and Braille, and vice versa. That makes is a little easier to switch the type of assistive support to be used. (It really doesn't make sense to have both speech/braille and assistive MathML on at once in any case.)