Skip to content

Make assistive-mml unset speech/braille and vice-versa #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpvc wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Make assistive-mml unset speech/braille and vice-versa #1388

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96f6e30
Make assistive-mml unset speech/braille and vice-versa
dpvc Nov 14, 2025
671b673
Add noRerender() function, as request in review
dpvc Nov 20, 2025
7e1618d
Add more information to the help dialog about hidden MathML.
dpvc Nov 20, 2025
1a65c63
Merge branch 'develop' into update/assistive-mml
dpvc Nov 20, 2025
5f3b73b
Fix formatting
dpvc Nov 20, 2025
c084317
Fix indentation.
dpvc Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ts/ui/menu/Menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,6 +1180,16 @@ export class Menu {
*/
protected setAssistiveMml(mml: boolean) {
this.document.options.enableAssistiveMml = mml;
if (mml) {
Menu.loading++; // pretend we're loading, to suppress rerendering for each variable change
if (this.settings.speech) {
this.menu.pool.lookup('speech').setValue(false);
}
if (this.settings.braille) {
this.menu.pool.lookup('braille').setValue(false);
}
Menu.loading--;
}
if (!mml || MathJax._?.a11y?.['assistive-mml']) {
this.rerender();
} else {
Expand Down Expand Up @@ -1213,6 +1223,11 @@ export class Menu {
protected setSpeech(speech: boolean) {
this.enableAccessibilityItems('Speech', speech);
this.document.options.enableSpeech = speech;
if (speech && this.settings.assistiveMml) {
Menu.loading++; // pretend we're loading, to suppress rerendering for each variable change
this.menu.pool.lookup('assistiveMml').setValue(false);
Menu.loading--;
}
if (!speech || MathJax._?.a11y?.explorer) {
this.rerender(STATE.COMPILED);
} else {
Expand All @@ -1226,6 +1241,11 @@ export class Menu {
protected setBraille(braille: boolean) {
this.enableAccessibilityItems('Braille', braille);
this.document.options.enableBraille = braille;
if (braille && this.settings.assistiveMml) {
Menu.loading++; // pretend we're loading, to suppress rerendering for each variable change
this.menu.pool.lookup('assistiveMml').setValue(false);
Menu.loading--;
}
if (!braille || MathJax._?.a11y?.explorer) {
this.rerender(STATE.COMPILED);
} else {
Expand Down