Fix nedb's usage of node:utils for Node 24
#521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkey patch node:util to include deprecated functions removed as of Node 24 but still needed by nedb
Half-Shot
reviewed
Sep 2, 2025
Contributor
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
Gooooooood god what a hack.
I'd be minded at this stage to rip out NeDB support entirely? How much work would that be?
Member
Author
It probably won't be much trouble, if at all -- the only concern is whether there should be a tool/script to migrate from NeDB to something else. |
Contributor
|
I think we built those out for a few bridges, and we've supported postgres for ages. I think it might be better to remove it at this point, it's super old. |
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of
nedbdon't work in Node 24 due to calling removednode:utilsAPIs.#519 bypassed that problem in unit tests by injecting the required
node:utilsfunctions, but that doesn't fix the problem in production or for anything that uses this SDK as a dependency.This PR moves that injection into source code to fix the problem outside of just tests. It also adds a deprecation warning log to make it clear that NeDB is no longer supported & should not be used anymore.