Skip to content

Conversation

@AndrewFerr
Copy link
Member

Depends on:

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@AndrewFerr AndrewFerr requested review from a team as code owners November 1, 2024 16:15
@t3chguy t3chguy changed the base branch from develop to af/widget-errors November 1, 2024 16:21
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew. This part looks straight forward.

@AndrewFerr AndrewFerr force-pushed the af/rtc-handle-ratelimiting branch from 2a605cf to 7156908 Compare November 7, 2024 21:31
Base automatically changed from af/widget-errors to develop November 9, 2024 07:46
Each request must be retried, as the non-legacy flow involves a sequence
of requests that must resolve in order.
@AndrewFerr AndrewFerr force-pushed the af/rtc-handle-ratelimiting branch from 7156908 to b96ae12 Compare November 9, 2024 08:33
robintown added a commit to robintown/element-call that referenced this pull request Nov 9, 2024
This bumps matrix-js-sdk to a preview branch that includes matrix-org/matrix-js-sdk#4498 and matrix-org/matrix-js-sdk#4494, and matrix-widget-api to 1.10.0.
@AndrewFerr AndrewFerr added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 10a4fd8 Nov 11, 2024
26 checks passed
@AndrewFerr AndrewFerr deleted the af/rtc-handle-ratelimiting branch November 11, 2024 03:12
hughns added a commit to element-hq/element-call that referenced this pull request Nov 11, 2024
hughns added a commit to element-hq/element-call that referenced this pull request Nov 11, 2024
Johennes pushed a commit to Johennes/matrix-js-sdk that referenced this pull request Feb 28, 2025
* MatrixRTCSession: handle rate limit errors

* Lint

* Handle ratelimiting for non-legacy state setting

Each request must be retried, as the non-legacy flow involves a sequence
of requests that must resolve in order.

* Fix broken test

* Check for MSC3757 instead of the unmerged MSC3779

* Move helper out of beforeEach

* Test ratelimit errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants