- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 648
 
Support for MSC2762 update_state widget action when running as embedded client #4662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    * Distinguish room state and timeline events in embedded clients This change enables room widget clients to take advantage of the more reliable method of communicating room state over the widget API provided by a recent update to MSC2762. * Add missing awaits * Upgrade matrix-widget-api
      
        
      
      
  
    4 tasks
  
              
                    hughns
  
              
              commented
              
                  
                    Jan 29, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getClientVersions()needs mocking- test case needed for when 
update_stateis not supported by widget host - test case needed for when 
update_stateis supported by widget host 
    
  toger5 
      added a commit
        to element-hq/element-call
      that referenced
      this pull request
    
      Feb 5, 2025 
    
    
      
  
    
      
    
  
This resolution was done because of: #2967 (comment) (broken es because it advocated the `UPDATE_STATE` widget-api version. In the longer term we dont need it. This can be merged only after we use a js-sdk version that is compatible with the `UPDATE_STATE` widget capaibility. Blocked on: matrix-org/matrix-js-sdk#4662
| 
           @robintown how does this fit into the rollout plan of update state?  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Implements #4665
This change enables room widget clients to take advantage of the more reliable method of communicating room state over the widget API provided by a recent update to MSC2762.
This capability was originally introduced in #4574 but then reverted in #4656 as it was not backwards compatible.
This PR should maintain compatibility so that embedded
RoomWidgetClientwill continue to work with widget container/hosts irrespective if they support the recent update to MSC2762.Checklist
public/exportedsymbols have accurate TSDoc documentation.