Allow the embedded client to work without update_state support #4849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
robintown
force-pushed
the
robin/embedded-no-update-state
branch
from
ffdb5b5 to
d805293
Compare
toger5
approved these changes
May 23, 2025
florianduros
approved these changes
May 23, 2025
| sendComplete: jest.fn(), | ||
| }; | ||
|
|
||
| public constructor(clientVersions: ApiVersion[]) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've revived the changes from #4662 that allow RoomWidgetClient to function even if the client into which it is embedded does not support the
update_stateaction.This seems useful for easing the transition outlined at https://github.com/element-hq/voip-internal/issues/289 with our upcoming Element Call release (for which we want to test some unrelated mobile changes, where mobile currently does not support
update_state), so I propose we add this compatibility layer.