Skip to content

Conversation

@bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Sep 3, 2025

Otherwise, when running against a server that doesn't support thread subscriptions, the client may falsely think that its thread subscriptions are not outdated (when receiving an empty, defaulted ThreadSubscriptions section in the SSS response). As a result, it would always use the store, not find most thread subscriptions, and conclude "nope, you haven't subscribed to any thread", which is wrong.

(Looking for support of MSC4306 is close to what we want, which would be support of MSC4308 itself, coming as part of element-hq/synapse#18695, and that will land despite MSC4306 being already advertised, but that's good enough, since it's unlikely many servers have enabled it by default yet.)

@bnjbvr bnjbvr requested a review from a team as a code owner September 3, 2025 10:44
@bnjbvr bnjbvr requested review from poljar and removed request for a team September 3, 2025 10:44
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.39%. Comparing base (acaff39) to head (6289124).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/room_list_service/mod.rs 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5618      +/-   ##
==========================================
- Coverage   88.40%   88.39%   -0.01%     
==========================================
  Files         355      355              
  Lines       97604    97610       +6     
  Branches    97604    97610       +6     
==========================================
+ Hits        86282    86287       +5     
+ Misses       7256     7255       -1     
- Partials     4066     4068       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed Performance Report

Merging #5618 will improve performances by 46.86%

Comparing bnjbvr/gate-tsub-extension-on-server-feature (6289124) with main (f12ee86)

Summary

⚡ 1 improvement
✅ 48 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
Restore session [memory store] 401.6 ms 273.5 ms +46.86%

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! Would love to get a test for that, it seems sensitive, thought?

@poljar poljar removed their request for review September 4, 2025 09:18
@bnjbvr
Copy link
Member Author

bnjbvr commented Sep 15, 2025

Sure, should be fairly trivial albeit verbose to test.

@bnjbvr bnjbvr force-pushed the bnjbvr/gate-tsub-extension-on-server-feature branch from ae4ce6e to cc23fdc Compare September 15, 2025 15:12
@bnjbvr bnjbvr requested a review from Hywan September 15, 2025 15:12
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bnjbvr bnjbvr force-pushed the bnjbvr/gate-tsub-extension-on-server-feature branch from cc23fdc to 6289124 Compare September 15, 2025 15:41
@bnjbvr bnjbvr enabled auto-merge (rebase) September 15, 2025 15:41
@bnjbvr bnjbvr merged commit e83f37e into main Sep 15, 2025
52 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/gate-tsub-extension-on-server-feature branch September 15, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants