-
Notifications
You must be signed in to change notification settings - Fork 336
fix(room service): enable the thread subscriptions extension based on server support #5618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
==========================================
- Coverage 88.40% 88.39% -0.01%
==========================================
Files 355 355
Lines 97604 97610 +6
Branches 97604 97610 +6
==========================================
+ Hits 86282 86287 +5
+ Misses 7256 7255 -1
- Partials 4066 4068 +2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5618 will improve performances by 46.86%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! Would love to get a test for that, it seems sensitive, thought?
|
Sure, should be fairly trivial albeit verbose to test. |
…server advertises support for it
ae4ce6e to
cc23fdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cc23fdc to
6289124
Compare
Otherwise, when running against a server that doesn't support thread subscriptions, the client may falsely think that its thread subscriptions are not outdated (when receiving an empty, defaulted
ThreadSubscriptionssection in the SSS response). As a result, it would always use the store, not find most thread subscriptions, and conclude "nope, you haven't subscribed to any thread", which is wrong.(Looking for support of MSC4306 is close to what we want, which would be support of MSC4308 itself, coming as part of element-hq/synapse#18695, and that will land despite MSC4306 being already advertised, but that's good enough, since it's unlikely many servers have enabled it by default yet.)