feat(push): add experimental support for applying "Do not Disturb" notification settings as per MSC4359#5687
feat(push): add experimental support for applying "Do not Disturb" notification settings as per MSC4359#5687Johennes wants to merge 1 commit intomatrix-org:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5687 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 359 359
Lines 99060 99063 +3
Branches 99060 99063 +3
=======================================
+ Hits 87570 87573 +3
+ Misses 7353 7351 -2
- Partials 4137 4139 +2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5687 will not alter performanceComparing Summary
|
eee8a98 to
7118250
Compare
7118250 to
98b11e8
Compare
…sturb" notification settings) Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
98b11e8 to
1292755
Compare
bnjbvr
left a comment
There was a problem hiding this comment.
Hi @Johennes, thanks for the contribution! I'm not against it in principle, but we're a bit concerned that adding support for experimental features like this adds significantly to the maintenance overhead of matrix-rust-sdk, and as such feel like it's probably a bit early to merge support for this into mainline, even when guarded by feature flags. Perhaps you could keep it in a fork for now, and we can revisit once the MSC (or the other) gets a bit more traction?
|
Oh. 😯 This actually seemed relatively minimal to me, especially when compared to its predecessor #5441. I understand the rationale though and keeping this in a fork is fine. If it's ok, I'll leave this pull request open in draft state because it's currently the only public implementation of the MSC. |
This adds partial support for matrix-org/matrix-spec-proposals#4359 and suppresses push notifications when a room is set to "Do not Disturb" (DnD). The DnD setting is sourced from a dedicated global account data event.