MSC4359: "Do not Disturb" notification settings#4359
Open
Johennes wants to merge 1 commit intomatrix-org:mainfrom
Open
MSC4359: "Do not Disturb" notification settings#4359Johennes wants to merge 1 commit intomatrix-org:mainfrom
Johennes wants to merge 1 commit intomatrix-org:mainfrom
Conversation
Johennes
changed the title
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
johannes/dnd
branch
from
47d33ec to
1fe13da
Compare
turt2live
added
push
proposal
turt2live
reviewed
Sep 17, 2025
Member
There was a problem hiding this comment.
Implementation requirements:
- Client
- Server
Contributor
Author
There was a problem hiding this comment.
Ruma (account-wide setting): ruma/ruma#2221
Rust SDK (account-wide setting): matrix-org/matrix-rust-sdk#5687
1 task
benkuly
reviewed
Sep 19, 2025
|
|
||
| ## Alternatives | ||
|
|
||
| [MSC3768] integrates DnD into the existing push rule system. This significantly increases the |
Contributor
There was a problem hiding this comment.
I think this is a cleaner way, because it won't introduce a new parallel approach. I also think it would be way easier to implement and test. At least on the client side in Trixnity and Trixnity Messenger, where I'm currently implementing notifications from scratch up.
Contributor
Author
There was a problem hiding this comment.
The main issue I ran into when implementing MSC3768 is https://github.com/matrix-org/matrix-spec-proposals/pull/3768/files#r2348952758.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered