docs: Clarify matrix.to URL scheme for Spaces on README (fixes #393) #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2025
Open
t3chguy
reviewed
Oct 13, 2025
README.md
Outdated
Comment on lines
60
to
61
| rooms. (Some servers call their "entrypoint" space literally `space`, in which case | ||
| the URL would be `https://matrix.to/#/#space:example.org`.) |
There was a problem hiding this comment.
This isn't helpful and will be misleading at best, e.g. matrix.org doesn't use #space but uses #community - in any case how is it helpful? The first sentence is probably fine, though I'd maybe remove the word regular given they are rooms of type m.space i.e not "regular" or default rooms
There was a problem hiding this comment.
@t3chguy I appreciate that you took the time to review this, and have updated it now as you suggested - better?
Based on matrix-org#394 (comment) feedback.
t3chguy
reviewed
Oct 14, 2025
| The #/ component is mandatory and exists to avoid leaking the target URL to the | ||
| server hosting matrix.to. | ||
|
|
||
| There is no _Entity type_ for **Spaces**, as they are technically really just rooms. |
There was a problem hiding this comment.
Suggested change
| There is no _Entity type_ for **Spaces**, as they are technically really just rooms. | |
| There is no _Entity type_ for **Spaces**, as they are technically just rooms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393.