Skip to content

Import run_in_background correctly from ModuleApi #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

Import run_in_background correctly from ModuleApi #138

merged 1 commit into from
Oct 10, 2025
+2 −2

Conversation

@anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Oct 10, 2025 •
edited
Loading

Otherwise one will receive the following exception:

  File "/home/synapse/synapse-s3-storage-provider/s3_storage_provider.py", line 146, in fetch
    self._module_api.run_in_background(
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'ModuleApi' object has no attribute 'run_in_background'

Missed in #134.

@anoadragon453 anoadragon453 changed the title Impor run_in_background correctly from ModuleApi Import run_in_background correctly from ModuleApi Oct 10, 2025
@anoadragon453 anoadragon453 marked this pull request as ready for review October 10, 2025 12:07
@anoadragon453 anoadragon453 requested a review from a team as a code owner October 10, 2025 12:07
@anoadragon453 anoadragon453 merged commit a3ef659 into main Oct 10, 2025
7 checks passed
@anoadragon453 anoadragon453 deleted the anoa/run_in_background_import branch October 10, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anoadragon453 @erikjohnston