Skip to content

Import run_in_background correctly from ModuleApi #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

Import run_in_background correctly from ModuleApi #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions s3_storage_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from twisted.python.threadpool import ThreadPool

from synapse.logging.context import make_deferred_yieldable
from synapse.module_api import ModuleApi
from synapse.module_api import ModuleApi, run_in_background
from synapse.rest.media.v1._base import Responder
from synapse.rest.media.v1.storage_provider import StorageProvider

Expand Down Expand Up @@ -143,7 +143,7 @@ async def fetch(self, path, file_info):
# We do, however, need to wrap in `run_in_background` to ensure that the
# coroutine returned by `defer_to_threadpool` is used, and therefore
# actually run.
self._module_api.run_in_background(
run_in_background(
self._module_api.defer_to_threadpool(
self._s3_pool,
s3_download_task,
Expand Down