Skip to content

💩 fix: fix broken zaaktype create due to Open Zaak update#347

Merged
svenvandescheur merged 2 commits intomainfrom
hotfix/create-zaaktype
Nov 4, 2025
Merged

💩 fix: fix broken zaaktype create due to Open Zaak update#347
svenvandescheur merged 2 commits intomainfrom
hotfix/create-zaaktype

Conversation

@svenvandescheur
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.25%. Comparing base (5d4f163) to head (df6d7b0).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
backend/src/openbeheer/utils/gherkin_e2e.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   70.32%   70.25%   -0.07%     
==========================================
  Files         164      164              
  Lines        5216     5231      +15     
  Branches      544      544              
==========================================
+ Hits         3668     3675       +7     
- Misses       1509     1517       +8     
  Partials       39       39              
Flag Coverage Δ
backend 90.44% <0.00%> (-0.32%) ⬇️
jest 25.29% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SilviaAmAm
Copy link

There is also this PR updating the image? #344

Copy link
Contributor

@CharString CharString left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message needs changing.
I agree with the 💩, but this is not a OZ problem; we erroneously inferred | None instead of | UNSET for unrequired non-nullable fields. This draft should fix it too.

@svenvandescheur
Copy link
Collaborator Author

The commit message needs changing. I agree with the 💩, but this is not a OZ problem; we erroneously inferred | None instead of | UNSET for unrequired non-nullable fields. This draft should fix it too.

@CharString Good remark, will change the commit message. Created #351 for the type update.

@svenvandescheur svenvandescheur merged commit c306da6 into main Nov 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants