Skip to content

💩 fix: fix broken zaaktype create due to Open Zaak update #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svenvandescheur merged 2 commits into from
Nov 4, 2025
Merged

💩 fix: fix broken zaaktype create due to Open Zaak update #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e11fc50
:poop: fix: woraround issue with broken zaaktype create due to #351
svenvandescheur Nov 4, 2025
df6d7b0
:white_check_mark: test: attempt to make the tests less flaky
svenvandescheur Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions backend/src/openbeheer/utils/gherkin_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,12 @@ def user_logs_out(self, page: Page) -> None:
profile_button.click()

# ¯\_(ツ)_/¯ - Attempt to fix flakiness in WebKit
if self.runner.browser.browser_type.name == "webkit":
is_webkit = self.runner.browser.browser_type.name == "webkit"
if is_webkit:
page.wait_for_timeout(120)

logout_button = page.get_by_role("button", name="Logout")
logout_button.wait_for()
logout_button.click()
logout_button.click(force=is_webkit)

# Navigation

Expand Down Expand Up @@ -323,6 +323,7 @@ class Then(GherkinScenario):
# Location

def url_should_be(self, page: Page, url: str) -> None:
page.wait_for_load_state("networkidle")
expect(page).to_have_url(url)

def url_should_match(self, page: Page, url: str) -> None:
Expand Down
7 changes: 4 additions & 3 deletions backend/src/openbeheer/zaaktype/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

from openbeheer.types import FrontendFieldSet, FrontendFieldsets, make_fields_optional
from openbeheer.types.ztc import (
Catalogus,
BronCatalogus,
BronZaaktype,
IndicatieInternOfExternEnum,
ReferentieProces,
VertrouwelijkheidaanduidingEnum,
Expand Down Expand Up @@ -278,8 +279,8 @@ def __post_init__(self):
),
"selectielijst_procestype": "",
"verantwoordelijke": "De verantwoordelijke (soort) organisatie.",
"broncatalogus": make_fields_optional(Catalogus)(url="", domein="", rsin=""),
"bronzaaktype": OptionalZaakType(identificatie="", omschrijving=""),
"broncatalogus": BronCatalogus(url="", domein="", rsin=""),
"bronzaaktype": BronZaaktype(url="", identificatie="", omschrijving=""),
"begin_geldigheid": date.today(),
"versiedatum": date.today(),
"catalogus": "",
Expand Down
Loading