feat: support multiple stop IDs in alerts config#62
Merged
digitalcora merged 1 commit intomainfrom May 30, 2025
Merged
Conversation
digitalcora
force-pushed
the
cfg-alerts-stop-ids
branch
from
620c80e to
1e04d93
Compare
deanshi
approved these changes
May 16, 2025
digitalcora
force-pushed
the
cfg-alerts-stop-ids
branch
2 times, most recently
from
176fc7d to
9bd2378
Compare
Contributor
Author
|
@deanshi If you wouldn't mind a re-review, after looking further into the |
deanshi
approved these changes
May 19, 2025
Contributor
|
Sorry I missed this comment, but all looks good still! |
This is narrowly-scoped rather than modifying the shared `Alerts` struct, since that would then require widget generation to support multiple stop IDs on all screen types, which would be a very complex change and is far out of scope for the current task of adding this to Bus E-ink screens only.
digitalcora
force-pushed
the
cfg-alerts-stop-ids
branch
from
9bd2378 to
2b9eb93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #61 for the implementation of
migrate_json/1, which this depends on.