Skip to content

feat: support multiple stop IDs in alerts config #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
digitalcora merged 1 commit into from
May 30, 2025
Merged

feat: support multiple stop IDs in alerts config #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/config/multi_stop_alerts.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
defmodule ScreensConfig.MultiStopAlerts do
@moduledoc "Configuration for screens that can show alerts for multiple stops."

@type t :: %__MODULE__{stop_ids: [String.t()]}

defstruct stop_ids: []

use ScreensConfig.Struct

# Allow migrating from `ScreensConfig.Alerts` which has a singular `stop_id`.
defp migrate_json(%{"stop_id" => stop_id} = json) when not is_nil(stop_id),
do: Map.put(json, "stop_ids", [stop_id])

defp migrate_json(other), do: other

defp value_from_json(_, value), do: value
defp value_to_json(_, value), do: value
end
6 changes: 3 additions & 3 deletions lib/config/screen/bus_eink.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ defmodule ScreensConfig.Screen.BusEink do
@moduledoc false
# credo:disable-for-this-file Credo.Check.Design.DuplicatedCode

alias ScreensConfig.{Alerts, Departures, EvergreenContentItem, Footer, Header}
alias ScreensConfig.{Departures, EvergreenContentItem, Footer, Header, MultiStopAlerts}

@type t :: %__MODULE__{
departures: Departures.t(),
footer: Footer.t(),
header: Header.t(),
alerts: Alerts.t(),
alerts: MultiStopAlerts.t(),
evergreen_content: list(EvergreenContentItem.t())
}

Expand All @@ -23,7 +23,7 @@ defmodule ScreensConfig.Screen.BusEink do
children: [
departures: Departures,
footer: Footer,
alerts: Alerts,
alerts: MultiStopAlerts,
evergreen_content: {:list, EvergreenContentItem}
]

Expand Down