Fix onclick handlers breaking on source names with special chars#107
Merged
mbuckingham74 merged 1 commit intomainfrom Dec 2, 2025
Merged
Fix onclick handlers breaking on source names with special chars#107mbuckingham74 merged 1 commit intomainfrom
mbuckingham74 merged 1 commit intomainfrom
Conversation
The |tojson filter outputs JSON with double quotes, which broke HTML attributes that also use double quotes. Added |e filter to HTML-escape the quotes to ", allowing names like "Kodiak Area Native Association (KANA)" to work correctly. Fixed in: - configure_source.html (3 showScrapeModal calls) - partials/generated_scraper.html (1 showScrapeModal call) - partials/source_list.html (1 openScrapeModal call) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|tojsonfilter outputs JSON with double quotes like"Kodiak Area Native Association (KANA)""and ends the attribute early|efilter to HTML-escape the quotes to"Root Cause
Files Changed
configure_source.html- 3 showScrapeModal callspartials/generated_scraper.html- 1 showScrapeModal callpartials/source_list.html- 1 openScrapeModal callTest plan
🤖 Generated with Claude Code