Skip to content

Fix onclick handlers breaking on source names with special chars #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbuckingham74 merged 1 commit into from
Dec 2, 2025
Merged

Fix onclick handlers breaking on source names with special chars #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backend/app/templates/admin/configure_source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h2 class="text-2xl font-bold text-gray-900 dark:text-white">Configure Source</h
hx-post="/admin/sources/{{ source.id }}/scrape"
hx-target="#scrape-modal-result"
hx-swap="innerHTML"
onclick="showScrapeModal({{ source.name|tojson }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})">
onclick="showScrapeModal({{ source.name|tojson|e }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})">
<svg class="w-4 h-4" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 4v5h.582m15.356 2A8.001 8.001 0 004.582 9m0 0H9m11 11v-5h-.581m0 0a8.003 8.003 0 01-15.357-2m15.357 2H15"></path>
</svg>
Expand Down Expand Up @@ -76,7 +76,7 @@ <h3 class="text-lg font-semibold text-green-800 dark:text-green-200 flex items-c
hx-post="/admin/sources/{{ source.id }}/scrape"
hx-target="#scrape-modal-result"
hx-swap="innerHTML"
onclick="showScrapeModal({{ source.name|tojson }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})">
onclick="showScrapeModal({{ source.name|tojson|e }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})">
<svg class="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M14.752 11.168l-3.197-2.132A1 1 0 0010 9.87v4.263a1 1 0 001.555.832l3.197-2.132a1 1 0 000-1.664z"></path>
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M21 12a9 9 0 11-18 0 9 9 0 0118 0z"></path>
Expand Down Expand Up @@ -120,7 +120,7 @@ <h3 class="text-lg font-semibold text-blue-800 dark:text-blue-200 flex items-cen
hx-post="/admin/sources/{{ source.id }}/scrape"
hx-target="#scrape-modal-result"
hx-swap="innerHTML"
onclick="showScrapeModal({{ source.name|tojson }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})">
onclick="showScrapeModal({{ source.name|tojson|e }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})">
<svg class="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M14.752 11.168l-3.197-2.132A1 1 0 0010 9.87v4.263a1 1 0 001.555.832l3.197-2.132a1 1 0 000-1.664z"></path>
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M21 12a9 9 0 11-18 0 9 9 0 0118 0z"></path>
Expand Down
2 changes: 1 addition & 1 deletion backend/app/templates/admin/partials/generated_scraper.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ <h3 class="text-lg font-semibold dark:text-white flex items-center gap-2">
hx-post="/admin/sources/{{ source.id }}/scrape"
hx-target="#scrape-modal-result"
hx-swap="innerHTML"
onclick="showScrapeModal({{ source.name|tojson }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})"
onclick="showScrapeModal({{ source.name|tojson|e }}, {{ 'true' if source.use_playwright or source.use_playwright is none else 'false' }})"
class="w-full px-4 py-3 bg-purple-600 hover:bg-purple-700 text-white font-medium rounded-lg transition-colors flex items-center justify-center gap-2">
<svg class="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M14.752 11.168l-3.197-2.132A1 1 0 0010 9.87v4.263a1 1 0 001.555.832l3.197-2.132a1 1 0 000-1.664z"></path>
Expand Down
2 changes: 1 addition & 1 deletion backend/app/templates/admin/partials/source_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@
hx-post="/admin/sources/{{ source.id }}/scrape"
hx-target="#scrape-modal-result"
hx-swap="innerHTML show:none"
onclick="openScrapeModal('{{ source.name }}')">
onclick="openScrapeModal({{ source.name|tojson|e }})">
Scrape
</button>
{% endif %}
Expand Down
Loading