Fix GitHub device flow failing when app returns from background#103
Merged
mcintyre94 merged 1 commit intomainfrom Mar 17, 2026
Merged
Fix GitHub device flow failing when app returns from background#103mcintyre94 merged 1 commit intomainfrom
mcintyre94 merged 1 commit intomainfrom
Conversation
URLSession raises networkConnectionLost when a request fires immediately after app resume. Catch transient URLErrors (networkConnectionLost, notConnectedToInternet, timedOut) in the polling loop and retry rather than surfacing them as fatal errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLError.networkConnectionLost(-1005), which was surfaced as "The network connection was lost" and killed the flowURLErrors (.networkConnectionLost,.notConnectedToInternet,.timedOut) inside the polling loop andcontinueto the next interval instead of throwingTest plan
🤖 Generated with Claude Code