Skip to content

Fix GitHub device flow failing when app returns from background #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcintyre94 merged 1 commit into from
Mar 17, 2026
Merged

Fix GitHub device flow failing when app returns from background #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Wisp/Services/GitHubDeviceFlowClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,15 @@ struct GitHubDeviceFlowClient: Sendable {
request.setValue("application/x-www-form-urlencoded", forHTTPHeaderField: "Content-Type")
request.httpBody = "client_id=\(Self.clientID)&device_code=\(deviceCode)&grant_type=urn:ietf:params:oauth:grant-type:device_code".data(using: .utf8)

let (data, response) = try await URLSession.shared.data(for: request)
let data: Data
let response: URLResponse
do {
(data, response) = try await URLSession.shared.data(for: request)
} catch let urlError as URLError where [.networkConnectionLost, .notConnectedToInternet, .timedOut].contains(urlError.code) {
// Transient failure — common when app returns from background. Retry on next interval.
logger.warning("Token poll transient network error: \(urlError.localizedDescription)")
continue
}

guard let httpResponse = response as? HTTPURLResponse,
(200...299).contains(httpResponse.statusCode) else {
Expand Down
Loading