Create issue, delete issue unit tests #709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2025
mdjnelson
reviewed
Aug 24, 2025
tests/event/events_test.php
Outdated
| $sink = $this->redirectEvents(); | ||
|
|
||
| // Trigger event manually. | ||
| \mod_customcert\event\issue_created::create([ |
There was a problem hiding this comment.
Rather than triggering this manually can we please call the functions that trigger this and then check the event is called?
mdjnelson
reviewed
Aug 24, 2025
tests/event/events_test.php
Outdated
| $DB->delete_records('customcert_issues', ['id' => $issueid]); | ||
|
|
||
| // Trigger event manually. | ||
| \mod_customcert\event\issue_deleted::create([ |
There was a problem hiding this comment.
Rather than triggering this manually can we please call the functions that trigger this and then check the event is called?
|
Please see comments I left and fix the Moodle Plugin CI complaints. |
|
@mdjnelson, please check if it is okay now. The one testcase that is failing is not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made for #686
@mdjnelson, here is the clean PR for create and delete unit test.