Bump ex_webrtc, set RTP sender codec #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
reviewed
Feb 18, 2025
Comment on lines
127
to
133
| Membrane.Logger.warning(""" | ||
| Cannot select expicitly video codec, while various video codecs have been negotiated. \ | ||
| This might be caused be passing `Membrane.RTP` to `Membrane.WebRTC.Sink` and allowing \ | ||
| to negotiate more than one video codec. | ||
|
|
||
| Negotiated video codecs: #{inspect(supported_video_codecs, pretty: true)} | ||
| """) |
Member
There was a problem hiding this comment.
Is this going to fail randomly, like before the fix? Shouldn't we raise here?
Comment on lines
169
to
173
| defp get_video_transceiver(pc) do | ||
| pc | ||
| |> PeerConnection.get_transceivers() | ||
| |> Enum.find(&(&1.kind == :video)) | ||
| end |
Member
There was a problem hiding this comment.
This finds the first video transceiver, while we can have multiple video tracks. Shouldn't we find the transceiver corresponding to the particular track?
mat-hek
approved these changes
Feb 18, 2025
Comment on lines
128
to
131
| Cannot select expicitly video codec, while various video codecs have been negotiated. \ | ||
| This might be caused be passing `Membrane.RTP` to `Membrane.WebRTC.Sink` and allowing \ | ||
| to negotiate more than one video codec. | ||
| Negotiated video codecs: #{inspect(supported_video_codecs, pretty: true)} |
Member
There was a problem hiding this comment.
Suggested change
| Cannot select expicitly video codec, while various video codecs have been negotiated. \ | |
| This might be caused be passing `Membrane.RTP` to `Membrane.WebRTC.Sink` and allowing \ | |
| to negotiate more than one video codec. | |
| Negotiated video codecs: #{inspect(supported_video_codecs, pretty: true)} | |
| Cannot determine the video codec of the stream. It's necessary, as multiple video codecs have been negotiated. \ | |
| This error might be caused by passing `Membrane.RTP` to `Membrane.WebRTC.Sink` and allowing \ | |
| to negotiate more than one video codec. | |
| Negotiated video codecs: #{inspect(supported_video_codecs, pretty: true)} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.