Skip to content

publish: esp-idf sleep_for() is broken article#554

Merged
gminn merged 2 commits intomasterfrom
gminn/publish-why-sleep-for-is-broken-article
Feb 20, 2025
Merged

publish: esp-idf sleep_for() is broken article#554
gminn merged 2 commits intomasterfrom
gminn/publish-why-sleep-for-is-broken-article

Conversation

@gminn
Copy link
Member

@gminn gminn commented Feb 19, 2025

Summary

Publish a new article, with minor adjustments to grammar.

Test Plan

  • Check link
  • Visual check

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 19, 2025

Deploying interrupt with  Cloudflare Pages  Cloudflare Pages

Latest commit: 55679bd
Status: ✅  Deploy successful!
Preview URL: https://416562c2.interrupt.pages.dev
Branch Preview URL: https://gminn-publish-why-sleep-for.interrupt.pages.dev

View logs

Copy link
Member Author

gminn commented Feb 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gminn gminn force-pushed the gminn/publish-why-sleep-for-is-broken-article branch 2 times, most recently from 7a55a55 to b55fa21 Compare February 19, 2025 22:31
@gminn gminn force-pushed the gminn/publish-why-sleep-for-is-broken-article branch from b55fa21 to 621def3 Compare February 19, 2025 22:39
@gminn gminn marked this pull request as ready for review February 19, 2025 22:40
@gminn gminn requested a review from a team as a code owner February 19, 2025 22:40
@gminn
Copy link
Member Author

gminn commented Feb 19, 2025

@stevenoonan Please take a look and let me know what you think of these minor adjustments!

Copy link
Contributor

@stevenoonan stevenoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits look great. Thanks!

@gminn
Copy link
Member Author

gminn commented Feb 20, 2025

@stevenoonan I made some final changes:

  • Remove backticks in title -- we don't currently support markdown formatting in article titles
  • Minor adjustments to C++ code formatting for readability

I'm going to merge this to trigger the publish, but let me know if you have any concerns!

@gminn gminn merged commit 5828347 into master Feb 20, 2025
3 checks passed
@gminn gminn deleted the gminn/publish-why-sleep-for-is-broken-article branch February 20, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants