Add support for ThermoPro-TP211B temperature sensor#3462
Open
a-rahimi wants to merge 1 commit intomerbanan:masterfrom
Open
Add support for ThermoPro-TP211B temperature sensor#3462a-rahimi wants to merge 1 commit intomerbanan:masterfrom
a-rahimi wants to merge 1 commit intomerbanan:masterfrom
Conversation
8258fc2 to
c9c5f90
Compare
|
Passing by: I'm not a maintainer, but it looks like you're missing a few changes (the doc and conf). Have you ran |
Author
|
thanks @n6ham updated the pr after running maintainer_update.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this based on the information from this issue.
Seems to work fine:
The temperatures what the sensor shows on its screen.