MM2 1473 Fix: set force flag to true for batch inventory deletion #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sylwia-werner
changed the title
sylwia-werner
changed the title
mikolvj
reviewed
Nov 9, 2025
Comment on lines
229
to
236
| mutationFn: (payload) => { | ||
| // force: true is required for admin batch endpoint to delete levels with stocked items | ||
| const payloadWithForce: HttpTypes.AdminBatchInventoryItemLocationLevels = { | ||
| ...payload, | ||
| force: payload?.delete?.length ? true : payload.force, | ||
| } | ||
|
|
||
| return sdk.admin.inventoryItem.batchInventoryItemLocationLevels( |
Collaborator
There was a problem hiding this comment.
- How about
force: !!payload?.delete?.length || payload.force - IMO we don't need to use separate const, we could just
return sdk.admin.inventoryItem.batchInventoryItemLocationLevels( inventoryItemId, {...payload, force: ....} )
Collaborator
Author
There was a problem hiding this comment.
Right, refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MM2-1473
Note: wait with merge until mercurjs/mercur#453 is merged