Skip to content

MM2 1473 Fix: set force flag to true for batch inventory deletion #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: testing
Choose a base branch
from
Open

MM2 1473 Fix: set force flag to true for batch inventory deletion #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bf3c5a
fix: require force set to true for batch inventory deletion
sylwia-werner Nov 5, 2025
c166a6b
refactor: simplify payload logic for batch inventory api call
sylwia-werner Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/hooks/api/inventory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,18 @@ export const useBatchInventoryItemLocationLevels = (
>
) => {
return useMutation({
mutationFn: (payload) =>
sdk.admin.inventoryItem.batchInventoryItemLocationLevels(
mutationFn: (payload) => {
// force: true is required for admin batch endpoint to delete levels with stocked items
const payloadWithForce: HttpTypes.AdminBatchInventoryItemLocationLevels = {
...payload,
force: payload?.delete?.length ? true : payload.force,
}

return sdk.admin.inventoryItem.batchInventoryItemLocationLevels(
Comment on lines 229 to 230
Copy link
Collaborator

@mikolvj mikolvj Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How about force: !!payload?.delete?.length || payload.force
  2. IMO we don't need to use separate const, we could just
    return sdk.admin.inventoryItem.batchInventoryItemLocationLevels( inventoryItemId, {...payload, force: ....} )

Copy link
Collaborator Author

@sylwia-werner sylwia-werner Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, refactored

inventoryItemId,
payload
),
payloadWithForce
)
},
onSuccess: (data, variables, context) => {
queryClient.invalidateQueries({
queryKey: inventoryItemsQueryKeys.lists(),
Expand Down Expand Up @@ -258,8 +265,15 @@ export const useBatchInventoryItemsLocationLevels = (
>
) => {
return useMutation({
mutationFn: (payload) =>
sdk.admin.inventoryItem.batchInventoryItemsLocationLevels(payload),
mutationFn: (payload) => {
// force: true is required for admin batch endpoint to delete levels with stocked items
const payloadWithForce: HttpTypes.AdminBatchInventoryItemsLocationLevels = {
...payload,
force: payload?.delete?.length ? true : payload.force,
}

return sdk.admin.inventoryItem.batchInventoryItemsLocationLevels(payloadWithForce)
},
onSuccess: (data, variables, context) => {
queryClient.invalidateQueries({
queryKey: inventoryItemsQueryKeys.all,
Expand Down