Improvement/add regions option support#59
Open
aoutfast wants to merge 3 commits intomergermarket:masterfrom
Open
Improvement/add regions option support#59aoutfast wants to merge 3 commits intomergermarket:masterfrom
aoutfast wants to merge 3 commits intomergermarket:masterfrom
Conversation
egocks
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adresses the issue with
aws4package usage, when it tries to get the AWS Region from the hostname.Use Case
When the AWS Elasticsearch domain is under a custom domain the signature won't be valid. If the node is hosted in another region than
us-east-1eg.
Expected domain Resulting Signature Valid ✅
https://xxxx.<region>.es.amazonaws.comAliased Domain Resulting Signature Invalid ❌
https://search.mydomain.comSnippet responsible for the region in
aws4Resolution
Adding
signOptas an optional param to generateAWSConnectionClass