Skip to content

Improvement/add regions option support #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoutfast wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improvement/add regions option support #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff215cc
Add region option for ES node alias domains, where the signer cannot …
Oct 6, 2021
9cd3d74
Add signOpt to entrypoint function createAWSConnection
Oct 6, 2021
6bd1eac
fix SignOpt type to default service to es and make region optional
Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ import { sign } from 'aws4'
import { ClientOptions, Connection, Transport } from '@elastic/elasticsearch'
import { ApiResponse, TransportRequestPromise } from '@elastic/elasticsearch/lib/Transport'

function generateAWSConnectionClass(credentials: Credentials) {
declare type SignOpt = {
service: 'es';
region?: string;
}

function generateAWSConnectionClass(credentials: Credentials, signOpts?: SignOpt) {
return class AWSConnection extends Connection {
public constructor(opts) {
super(opts)
Expand All @@ -15,7 +20,7 @@ function generateAWSConnectionClass(credentials: Credentials) {
private signedRequest(reqParams: ClientRequestArgs): ClientRequest {
const request = reqParams?.protocol === 'https:' ? httpsRequest : httpRequest

return request(sign({ ...reqParams, service: 'es' }, credentials))
return request(sign({ ...reqParams, service: 'es', ...signOpts }, credentials))
}
}
}
Expand Down Expand Up @@ -54,9 +59,9 @@ function generateAWSTransportClass(credentials: Credentials) {
};
}

export function createAWSConnection(awsCredentials: Credentials): ClientOptions {
export function createAWSConnection(awsCredentials: Credentials, signOpts?: SignOpt): ClientOptions {
return {
Connection: generateAWSConnectionClass(awsCredentials),
Connection: generateAWSConnectionClass(awsCredentials, signOpts),
Transport: generateAWSTransportClass(awsCredentials)
}
}
Expand Down