[hyperactor] mesh: ensure liveness for proc and actor spawning #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter `PROC_SPAWN_MAX_IDLE` and `ACTOR_SPAWN_MAX_IDLE`. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this. We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure. Differential Revision: [D83882826](https://our.internmc.facebook.com/intern/diff/D83882826/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83882826/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 3, 2025
Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter `PROC_SPAWN_MAX_IDLE` and `ACTOR_SPAWN_MAX_IDLE`. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this. We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure. Differential Revision: [D83882826](https://our.internmc.facebook.com/intern/diff/D83882826/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83882826/)! ghstack-source-id: 314019055 Pull Request resolved: #1426
meta-cla
bot
added
the
CLA Signed
…ning" Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter `PROC_SPAWN_MAX_IDLE` and `ACTOR_SPAWN_MAX_IDLE`. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this. We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure. Differential Revision: [D83882826](https://our.internmc.facebook.com/intern/diff/D83882826/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83882826/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 3, 2025
Pull Request resolved: #1426 Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter `PROC_SPAWN_MAX_IDLE` and `ACTOR_SPAWN_MAX_IDLE`. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this. We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure. ghstack-source-id: 314021969 @exported-using-ghexport Differential Revision: [D83882826](https://our.internmc.facebook.com/intern/diff/D83882826/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83882826/)!
…ning" Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter `PROC_SPAWN_MAX_IDLE` and `ACTOR_SPAWN_MAX_IDLE`. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this. We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure. Differential Revision: [D83882826](https://our.internmc.facebook.com/intern/diff/D83882826/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83882826/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 5, 2025
Pull Request resolved: #1426 Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter `PROC_SPAWN_MAX_IDLE` and `ACTOR_SPAWN_MAX_IDLE`. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this. We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure. ghstack-source-id: 314156438 @exported-using-ghexport Differential Revision: [D83882826](https://our.internmc.facebook.com/intern/diff/D83882826/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83882826/)!
This was referenced Oct 6, 2025
…ning" Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter `PROC_SPAWN_MAX_IDLE` and `ACTOR_SPAWN_MAX_IDLE`. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this. We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure. Differential Revision: [D83882826](https://our.internmc.facebook.com/intern/diff/D83882826/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D83882826/)! [ghstack-poisoned]
|
This pull request has been merged in 90c6202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Make proc and actor spawning subject to a liveness parameter: we expect the spawn to either complete, or else yile updated regularly (configured by a new parameter
PROC_SPAWN_MAX_IDLEandACTOR_SPAWN_MAX_IDLE. This is a bridge solution to provide good error messaging, and to prevent applications from halting. Once we have owned host meshes w/ their own comm actors, we can use the general purpose liveness mechanism for this.We also clean up the error messages, refactor the status fence, and print the status of each individual proc on failure.
Differential Revision: D83882826
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!